Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix optional chaining on non-null segment #4901

Merged
merged 1 commit into from Dec 10, 2022
Merged

Fix optional chaining on non-null segment #4901

merged 1 commit into from Dec 10, 2022
+7 −2

Conversation

distantnative
Copy link
Member

@distantnative distantnative commented Dec 7, 2022 •
edited

This PR …

Fixes

  • Kirby queries: optional chaining on non-null values works now properly

Ready?

  • Unit tests for fixed bug/feature
  • In-code documentation (wherever needed)
  • Tests and checks all pass

For review team

@distantnative distantnative added the type: bug 🐛 Is a bug; fixes a bug label Dec 7, 2022
@distantnative distantnative self-assigned this Dec 7, 2022
@distantnative distantnative requested a review from a team December 7, 2022 18:25
@distantnative distantnative merged commit 4b10ca6 into develop Dec 10, 2022
@distantnative distantnative deleted the fix/query-optional branch December 10, 2022 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukasbestle lukasbestle lukasbestle approved these changes

Assignees

@distantnative distantnative

Labels
type: bug 🐛 Is a bug; fixes a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@distantnative @lukasbestle