Skip to content

Files upload: use upload.parent for mime check #5245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 7, 2023

Conversation

distantnative
Copy link
Member

Files field on a file blueprint would throw an error now as using $this->model() would pass a File object as File to create a new File. Which our native type hints now prevent. Instead, we need to use upload.parent for the check, not the field parent.

@distantnative distantnative added this to the 4.0.0-alpha.3 milestone Jun 4, 2023
@distantnative distantnative requested a review from a team June 4, 2023 14:08
@distantnative distantnative self-assigned this Jun 4, 2023
@bastianallgeier bastianallgeier merged commit b6cb794 into v4/main Jun 7, 2023
@bastianallgeier bastianallgeier deleted the v4/fix/files-upload-parent branch June 7, 2023 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants