Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark temperamental test as xfail #192

Merged
merged 3 commits into from Feb 21, 2016
Merged

Mark temperamental test as xfail #192

merged 3 commits into from Feb 21, 2016

Conversation

RazerM
Copy link
Collaborator

@RazerM RazerM commented Feb 16, 2016

Also forgot to push one commit for #191 which I've added here...

Hopefully AppVeyor passes and it can be merged

Various discussions online about this issue on Python 3.2/3.3 with in memory sqlite databases.

xfail rather than skip because sometimes it passes
@RazerM
Copy link
Collaborator Author

RazerM commented Feb 16, 2016

It seems #175 wasn't fixed after all—there should be a check similar to Travis

@RazerM
Copy link
Collaborator Author

RazerM commented Feb 16, 2016

I'm getting a test failure in test_logged_if_slow_did_not_reached. Let's hold off on merge until I see what's going on.

@RazerM
Copy link
Collaborator Author

RazerM commented Feb 19, 2016

Ok I don't know what's going on with the test that failed, it's back to passing again. This can be merged, if all looks fine to you.

vmalloc added a commit that referenced this pull request Feb 21, 2016
Mark temperamental test as xfail
@vmalloc vmalloc merged commit 09b1361 into getlogbook:master Feb 21, 2016
@vmalloc
Copy link
Collaborator

vmalloc commented Feb 21, 2016

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants