feat: optional to/from methods on Reflector. (#150) #152
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Separates the
has_reflector
concept intohas_read_reflector
andhas_write_reflector
to allow allow Reflector types to be just readable, just writable, or both readable and writable.Adds test cases. The tests are slightly altered from the original
test_reflector
implementation. They now use a small class hierarchy (Person
andParent
) with fields in each class, which is not supported by default. The Reflector implementation in the tests flattens the hierarchy. Test cases for Reflector implementations with only theto
and only thefrom
method are present.Adds a paragraph to the docs mentioning the user-facing changes.
Fixes issue: #150