New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend test cert validity to 2049 #2500
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to make tests pass in 2027 Background: As part of my work on reproducible builds for openSUSE, I check that software still gives identical build results in the future. The usual offset is +15 years, because that is how long I expect some software will be used in some places. This showed up failing tests in our package build. See https://reproducible-builds.org/ for why this matters. Note: I tested that i586 builds still pass tests on 2036-12-01 so are not affected by the year 2038 bug yet. i586 builds in 2037 suffer from a y2038 bug (unrelated to this change): botocore/utils.py parse_timestamp threw a ValueError: Invalid timestamp "2174774434": Parser must be a string or character stream, not long
|
Here is the cert in the PR for the curious: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Extend test cert validity to 2049
to make tests pass in 2027
Background:
As part of my work on reproducible builds for openSUSE, I check
that software still gives identical build results in the future.
The usual offset is +15 years, because that is how long I expect
some software will be used in some places.
This showed up failing tests in our package build.
See https://reproducible-builds.org/ for why this matters.
Note: I tested that i586 builds still pass tests on 2036-12-01
so are not affected by the year 2038 bug yet.
i586 builds in 2037 suffer from a y2038 bug (unrelated to this change):
botocore/utils.py parse_timestamp threw a
ValueError: Invalid timestamp "2174774434": Parser must be a string or character stream, not long