Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Route53 list tags for resources #7867

Merged
merged 12 commits into from
Jul 24, 2024

Conversation

armichaud
Copy link
Contributor

@armichaud armichaud commented Jul 18, 2024

Implements Route53.Client.list_tags_for_resources API

@armichaud armichaud marked this pull request as ready for review July 19, 2024 09:12
@armichaud
Copy link
Contributor Author

Hey @bblommers , it looks like my unit test is failing when trying to call ChangeTagsForResource. This is definitely a valid boto3 API, and the test is passing when I run it locally. Are there particularities to the remote test runner that I've missed?

moto/route53/urls.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@bblommers bblommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thank you for implementing this @armichaud!

@bblommers bblommers added this to the 5.0.12 milestone Jul 24, 2024
Copy link

codecov bot commented Jul 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.35%. Comparing base (ba76bca) to head (8046a57).
Report is 12 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff            @@
##           master    #7867    +/-   ##
========================================
  Coverage   94.34%   94.35%            
========================================
  Files        1113     1113            
  Lines       94417    94650   +233     
========================================
+ Hits        89081    89307   +226     
- Misses       5336     5343     +7     
Flag Coverage Δ
servertests 29.21% <33.33%> (-0.04%) ⬇️
unittests 94.32% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bblommers bblommers merged commit b6bb11e into getmoto:master Jul 24, 2024
44 of 45 checks passed
Copy link
Contributor

This is now part of moto >= 5.0.12.dev35

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants