Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use dropdown menus on the Nikola website #21

Merged
merged 1 commit into from Jul 2, 2015
Merged

Use dropdown menus on the Nikola website #21

merged 1 commit into from Jul 2, 2015

Conversation

@Kwpolska
Copy link
Member

Kwpolska commented Jun 21, 2015

  • faster access to the documentation and support options
  • less clicks and reloads
  • links not buried in the support document
  • accessibility issues (might not even work…)
  • harder to access the “index” pages

@ralsina, your opinion: merge or drop?

Review on Reviewable

Signed-off-by: Chris Warrick <kwpolska@gmail.com>
@ralsina
Copy link
Member

ralsina commented Jul 2, 2015

LGTM


Comments from the review on Reviewable.io

@ralsina
Copy link
Member

ralsina commented Jul 2, 2015

Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks pending.


Comments from the review on Reviewable.io

ralsina added a commit that referenced this pull request Jul 2, 2015
Use dropdown menus on the Nikola website
@ralsina ralsina merged commit dea09ef into master Jul 2, 2015
@Kwpolska Kwpolska deleted the dropdown-menus branch Jul 17, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.