Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some preview images are not representative of the theme #140

Closed
tritium21 opened this issue Jan 11, 2018 · 5 comments
Closed

Some preview images are not representative of the theme #140

tritium21 opened this issue Jan 11, 2018 · 5 comments

Comments

@tritium21
Copy link

tritium21 commented Jan 11, 2018

The preview image below is rendered incorrectly, compared to how it actually renders.

bnw

This is how it renders in Firefox (probably correct.)

firefox_2018-01-11_05-38-22

@ralsina
Copy link
Member

ralsina commented Jan 11, 2018

Well, that depends on what fonts you have in the system, doesn't it?

@Kwpolska
Copy link
Member

This is caused by PhantomJS being terribly outdated. We could fix it with headless Chrome and Puppeteer for example.

@tritium21
Copy link
Author

I was more concerned with phantomjs apparently choosing to render text in arbitrarily wrong locations

@Kwpolska
Copy link
Member

Well, that’s what I’m talking about: PhantomJS’s engine is outdated and isn’t as good at new CSS tricks as Chrome/Firefox. Font faces chosen is irrelevant.

@Kwpolska
Copy link
Member

Fixed in commit be97dd1 by using Puppeteer. Needs one-time config and a Chrome/ium install, comes with much more accurate screenshots.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants