New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some preview images are not representative of the theme #140
Comments
Well, that depends on what fonts you have in the system, doesn't it? |
This is caused by PhantomJS being terribly outdated. We could fix it with headless Chrome and Puppeteer for example. |
I was more concerned with phantomjs apparently choosing to render text in arbitrarily wrong locations |
Well, that’s what I’m talking about: PhantomJS’s engine is outdated and isn’t as good at new CSS tricks as Chrome/Firefox. Font faces chosen is irrelevant. |
Fixed in commit be97dd1 by using Puppeteer. Needs one-time config and a Chrome/ium install, comes with much more accurate screenshots. |
The preview image below is rendered incorrectly, compared to how it actually renders.
This is how it renders in Firefox (probably correct.)
The text was updated successfully, but these errors were encountered: