New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metadata #122

Merged
merged 1 commit into from Aug 15, 2017

Conversation

Projects
None yet
2 participants
@ralsina
Member

ralsina commented May 24, 2017

Quick minimal metadata addition. Please review carefully, I am not sure what I'm doing.

Building the site currently fails on reveal at least.

@Kwpolska

This comment has been minimized.

Show comment
Hide comment
@Kwpolska

Kwpolska May 25, 2017

Member

This is a good first attempt, but attribution and licensing (and perhaps tags) still needs to be done:

  • attribution for adapted themes (eg. lanyon) based_on = Bootstrap 3 <https://getbootstrap.com/>
  • licenses: if we don’t have a license specified, it’s safer to say unknown
  • author: Roberto Alsina or other names will work better in many of those themes
Member

Kwpolska commented May 25, 2017

This is a good first attempt, but attribution and licensing (and perhaps tags) still needs to be done:

  • attribution for adapted themes (eg. lanyon) based_on = Bootstrap 3 <https://getbootstrap.com/>
  • licenses: if we don’t have a license specified, it’s safer to say unknown
  • author: Roberto Alsina or other names will work better in many of those themes
@ralsina

This comment has been minimized.

Show comment
Hide comment
@ralsina

ralsina May 25, 2017

Member

For those I wrote, I don't mind. For the others, yes, we have to look at each one. At least now the files would be in place.

Member

ralsina commented May 25, 2017

For those I wrote, I don't mind. For the others, yes, we have to look at each one. At least now the files would be in place.

@Kwpolska

This comment has been minimized.

Show comment
Hide comment
@Kwpolska

Kwpolska May 25, 2017

Member

Well, I do mind you not being attributed. Since we still support the old files, no need to rush.

Member

Kwpolska commented May 25, 2017

Well, I do mind you not being attributed. Since we still support the old files, no need to rush.

@ralsina

This comment has been minimized.

Show comment
Hide comment
@ralsina

ralsina May 25, 2017

Member
Member

ralsina commented May 25, 2017

Add metadata for themes
Signed-off-by: Chris Warrick <kwpolska@gmail.com>
@Kwpolska

This comment has been minimized.

Show comment
Hide comment
@Kwpolska

Kwpolska Aug 15, 2017

Member

Finished this. I don’t have time to track down submodule themes, I’ll get to it someday.

Member

Kwpolska commented Aug 15, 2017

Finished this. I don’t have time to track down submodule themes, I’ll get to it someday.

@Kwpolska Kwpolska merged commit 394bdf5 into master Aug 15, 2017

@Kwpolska Kwpolska deleted the metadata branch Aug 15, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment