Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add jidn theme #132

Merged
merged 1 commit into from Aug 28, 2017
Merged

Add jidn theme #132

merged 1 commit into from Aug 28, 2017

Conversation

jidn
Copy link
Contributor

@jidn jidn commented Aug 28, 2017

Based on the Lanyon theme and inspired by a blog with author information
at post end. See more at jidn/nikola-jidn

There is a demo post using this theme, and describing the settings, at
http://jidn.com/blog/jidn-a-nikola-theme/

Based on the Lanyon theme and inspired by a blog with author information
at post end.  See more at https://github.com/jidn/nikola-jidn
@ralsina
Copy link
Member

ralsina commented Aug 28, 2017

Nice!!!!

@ralsina ralsina merged commit 057eebe into getnikola:master Aug 28, 2017
@ralsina
Copy link
Member

ralsina commented Aug 28, 2017

It will appear in the site at some point in the future :-)

@Kwpolska
Copy link
Member

Kwpolska commented Aug 29, 2017

The theme’s great, but perhaps you could commit your files directly to this repo, as opposed to using a submodule? That would make it easier for us to maintain it, and you’ll of course get commit rights to this repository.

@jidn
Copy link
Contributor Author

jidn commented Aug 29, 2017

How do you want me to proceed? Create a branch, replace the submodule, alter the .gitmodules, and submit a pull request?

@Kwpolska
Copy link
Member

Kwpolska commented Aug 29, 2017

Yes. Make sure the submodule is forgotten by git (git rm; deinit should do it too)

@jidn jidn deleted the jidn branch Aug 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants