Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[zen] Usage of ForkAwesome icon fonts instead of FontAwesome #151

Closed
wants to merge 3 commits into from
Closed

[zen] Usage of ForkAwesome icon fonts instead of FontAwesome #151

wants to merge 3 commits into from

Conversation

@encarsia
Copy link
Contributor

@encarsia encarsia commented Apr 24, 2018

I modified the zen theme to use icons from the ForkAwesome project instead of the originally used FontAwesome icons which is in active development and contains more icons.

Currently FontAwesome v.3.2.1 is still used which has been deprecated for a while now.

@Kwpolska
Copy link
Member

@Kwpolska Kwpolska commented Apr 24, 2018

@encarsia
Copy link
Contributor Author

@encarsia encarsia commented Apr 24, 2018

What's wrong with Font Awesome 5?

Nothing, I guess. But Fork Awesome has Mastodon and other FLOSS related icons Font Awesome hasn't.

Also, any changes need to be migrated to zen-jinja.

Done.

Regards
Anke

@ralsina
Copy link
Member

@ralsina ralsina commented Apr 24, 2018

Why not make it a separate theme instead?

Inherit zen, then change only the parts that need changing.

@encarsia
Copy link
Contributor Author

@encarsia encarsia commented Apr 25, 2018

That would be fine for me, too.

So I basically revert changes I made in the existing themes and create a new one based on zen.

@Kwpolska
Copy link
Member

@Kwpolska Kwpolska commented Apr 25, 2018

zen could be upgraded to fontawesome v4. A v5 upgrade could also be done, but that one requires updating font references (eg. fab fa-twitter because Twitter is now in the “brand” icon set)

@ralsina
Copy link
Member

@ralsina ralsina commented Apr 25, 2018

+1 to making a zen fork and to upgrading zen to FA v4 (but not really important)

@encarsia
Copy link
Contributor Author

@encarsia encarsia commented Apr 26, 2018

zen could be upgraded to fontawesome v4

Since ForkAwesome is a FA 4.7 fork and going with FA 4.7 on my personal site this is doable. It appears logical to start with this task first before creating the zen fork to achieve my initial request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants