Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hyde theme] Re-center listings without line numbers (fixes #155 regression) #157

Conversation

Projects
None yet
2 participants
@hartwork
Copy link
Contributor

commented May 21, 2018

@ralsina what do you think?

Original (before 93bae02)

hyde_original

Broken status quo

hyde_before

With pull request applied

hyde_after

@hartwork hartwork changed the title Re-center listings without line numbers (fixes #155 regression) [hyde theme] Re-center listings without line numbers (fixes #155 regression) May 21, 2018

@Kwpolska

This comment has been minimized.

Copy link
Member

commented May 21, 2018

Why not make these code blocks full-width?

@hartwork

This comment has been minimized.

Copy link
Contributor Author

commented May 21, 2018

It does not look cool, at least not with this very theme, it fits other themes better. If it was made full width, it would need other adjustments as well, probably a different background color, adjusted padding, maybe a single-pixel border or so. I'd rather not go there, it was beautiful until recently.

@Kwpolska
Copy link
Member

left a comment

No, this looks terrible.

@hartwork

This comment has been minimized.

Copy link
Contributor Author

commented May 21, 2018

This is what listings without numbers looked like until a day ago, prior to 93bae02. This is about repair.

@Kwpolska

This comment has been minimized.

Copy link
Member

commented May 21, 2018

Okay, but let’s make it look better and make both code blocks look the same way.

@hartwork

This comment has been minimized.

Copy link
Contributor Author

commented May 21, 2018

That's a new pull request in my eyes. Let's fix the regression first, please.

@hartwork

This comment has been minimized.

Copy link
Contributor Author

commented May 23, 2018

Please please 😃

@Kwpolska

This comment has been minimized.

Copy link
Member

commented May 23, 2018

No, please do it the right way in this PR.

@hartwork

This comment has been minimized.

Copy link
Contributor Author

commented May 23, 2018

I disagree about what you call the right way and we have two distinct topics here. If this is a power game, I'm out.

@hartwork hartwork closed this May 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.