Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hyde theme] Unbreak code listing #159

Merged
merged 2 commits into from May 28, 2018

Conversation

@hartwork
Copy link
Contributor

@hartwork hartwork commented May 28, 2018

Click the thumbnails for life size versions. Please consider for application.

Prior to 93bae02 — current — with pull request

0_initial_w150 1_current_w150 2_after_w150

Thank, Sebastian

@hartwork hartwork changed the title Unbreak hyde code listing [hyde theme] Unbreak code listing May 28, 2018
@Kwpolska Kwpolska merged commit 868c415 into getnikola:master May 28, 2018
@Kwpolska
Copy link
Member

@Kwpolska Kwpolska commented May 28, 2018

I’m merging this, but IMO it would still be nice to have consistency between both styles of blocks, so perhaps you could create a PR for that as well?

@hartwork
Copy link
Contributor Author

@hartwork hartwork commented May 28, 2018

Thank you!

I find the no-numbers version more friendly and use it in my blog, exclusively. Those two being different can be seen as a feature: Authors get to choose between a light, friendly version without line numbers for shorter things, fewer distractions, and a serious version with full width, a frame and numbers that you can refer to in the text after. Why take that choice away?

@Kwpolska
Copy link
Member

@Kwpolska Kwpolska commented May 28, 2018

Because if you do have the “choice”, you might end up having both styles in one post, which looks inconsistent. If someone wants the lighter style, they could modify CSS to their will.

@hartwork hartwork deleted the hartwork:unbreak-hyde-code-listing branch May 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants