Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

foundation6 for Nikola 8 #161

Merged
merged 3 commits into from Jul 18, 2018
Merged

Conversation

okin
Copy link
Member

@okin okin commented Jul 17, 2018

Ported foundation6 to work with Nikola 8.

I removed Mathjax support for an easy port as I don't currently use this.
This is a change from the v7 version so I added an note.

Let me know if I should try to keep support for Mathjax!

@Kwpolska Kwpolska merged commit 916579a into getnikola:master Jul 18, 2018
Kwpolska added a commit that referenced this issue Jul 18, 2018
@Kwpolska
Copy link
Member

@Kwpolska Kwpolska commented Jul 18, 2018

Looks pretty good, thanks! I added math support myself and merged it. (Look at commit ec04411, it was pretty simple.)

One more thing: you may want to reconsider the license, as the AGPL imposes several troublesome limitations for potential users. Would it force users to release their blog posts under a copyleft license? Or just the site source? (It’s famously banned at Google, for example.)

@okin
Copy link
Member Author

@okin okin commented Oct 1, 2018

@Kwpolska re. license: I want changes made to the theme to be available as open source - so everyone can benefit from this.
I don't see this applying to the whole blog (incl. posts) so if someone uses the theme as-is this shouldn't be an issue.

@okin okin deleted the feature/foundation6_for_nikola_8 branch Oct 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants