Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Google Analytics and PACE.js options #59

Closed
wants to merge 4 commits into from
Closed

Conversation

@matuu
Copy link
Contributor

matuu commented Sep 30, 2015

Also updated base_helper.html

@da2x
Copy link

da2x commented Sep 30, 2015

ANALYTICS is a no-go. BODY_END already fulfills this purpose and is documented as such in conf.py and this new setting adds no advantages over that.

@matuu
Copy link
Contributor Author

matuu commented Sep 30, 2015

It recommend placing the snippet at the end of the section for best performance. BODY_END places the snippet at the end of the body section. See https://support.google.com/analytics/answer/1008080?hl=en#GA

Directly from Google:

One of the main advantages of the asynchronous snippet is that you can position it at the top of the HTML document. This increases the likelihood that the tracking beacon will be sent before the user leaves the page. It is customary to place JavaScript code in the head section, and we recommend placing the snippet at the bottom of the section for best performance.

@ralsina
Copy link
Member

ralsina commented Sep 30, 2015

@matuu then you can add it in EXTRA_HEAD_DATA :-)

@matuu
Copy link
Contributor Author

matuu commented Sep 30, 2015

Ok, I like that. I'll fix it

@ralsina ralsina closed this Aug 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.