Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Libretto theme #97

Merged
merged 1 commit into from Feb 17, 2017
Merged

Libretto theme #97

merged 1 commit into from Feb 17, 2017

Conversation

@abrahamvarricatt
Copy link
Contributor

@abrahamvarricatt abrahamvarricatt commented Feb 17, 2017

Adding a new theme for Nikola. Hope this gets accepted. :)

Adding a new theme for Nikola. Hope this gets accepted. :)
@ralsina ralsina merged commit f91b8ed into getnikola:master Feb 17, 2017
supported with this theme,

* 3rd-party comment system (is it even possible to do this without JS ?)
* Tags
Copy link
Member

@Kwpolska Kwpolska Feb 17, 2017

Why not?

Copy link
Contributor Author

@abrahamvarricatt abrahamvarricatt Feb 17, 2017

The original theme didn't have any UI for it. I didn't want to 'improvise' too much. Already did that for the archives part.

@@ -0,0 +1,28 @@
<?xml version="1.0" encoding="UTF-8"?>
Copy link
Member

@Kwpolska Kwpolska Feb 17, 2017

No need to duplicate this file.

Copy link
Contributor Author

@abrahamvarricatt abrahamvarricatt Feb 17, 2017

I'm not inheriting from base for this theme. It's a 'from scratch' implementation. On my browser at least, things work better with this file included.

@Kwpolska
Copy link
Member

@Kwpolska Kwpolska commented Feb 17, 2017

The theme looks pretty good, but tags are pretty important. Could you please work on making them work? Leaving the built-in template from base would work better than an empty page.

@abrahamvarricatt
Copy link
Contributor Author

@abrahamvarricatt abrahamvarricatt commented Feb 17, 2017

@Kwpolska Hmmm... alright. Give me a few days to figure out how best to represent tags and I'll add those template files too.

@ralsina Thanks for merging this in so quickly! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants