[idea] Remove double-negative settings #1076

Closed
Kwpolska opened this Issue Feb 24, 2014 · 4 comments

4 participants

@Kwpolska
Nikola, a static site generator member

We have at least two of those: HIDE_UNTRANSLATED_POSTS and HIDE_SOURCELINK. Double-negative settings are settings that are expressed like this (in GUI form):

[X] Do not eat my cat

This is a bit nonsense and may lead to mistakes (box is checked but the answer is actually no). In order for the above to make more sense, one needs to do:

[ ] Eat my cat

instead. In our case, SHOW_UNTRANSLATED_POSTS and SHOW_SOURCELINK, both defaulting to True.

@Kwpolska Kwpolska added this to the v7.0.0 milestone Feb 24, 2014
@damianavila
Nikola, a static site generator member

I completely agree with this observation...

@asmeurer

I don't disagree.

@ralsina
Nikola, a static site generator member

This doesn't break backwards compatibility at all. We can add new SHOW_UNTRANSLATED_POST option, give it priority over HIDE_ and give a warning if they contradict each other. I did the same thing a bunch of times alreay.

@Kwpolska Kwpolska self-assigned this Feb 26, 2014
@Kwpolska Kwpolska modified the milestone: v6.5.0, v7.0.0 Feb 26, 2014
@Kwpolska
Nikola, a static site generator member

In any case — this will be handled in whatever v6.4.0 + 1 happens to be.

@Kwpolska Kwpolska added a commit that referenced this issue Mar 2, 2014
@Kwpolska Kwpolska Fix #1076 -- remove double negative settings (invert HIDE_* into SHOW…
…_*).

new                     =     old                     = default
SHOW_SOURCELINK         = not HIDE_SOURCELINK         = True
SHOW_UNTRANSLATED_POSTS = not HIDE_UNTRANSLATED_POSTS = True

Signed-off-by: Chris “Kwpolska” Warrick <kwpolska@gmail.com>
f5ac026
@Kwpolska Kwpolska added a commit that referenced this issue Mar 3, 2014
@Kwpolska Kwpolska Fix #1076 -- remove double negative settings (invert HIDE_* into SHOW…
…_*).

new                     =     old                     = default
SHOW_SOURCELINK         = not HIDE_SOURCELINK         = True
SHOW_UNTRANSLATED_POSTS = not HIDE_UNTRANSLATED_POSTS = True

Signed-off-by: Chris “Kwpolska” Warrick <kwpolska@gmail.com>
13cebac
@Kwpolska Kwpolska added a commit that referenced this issue Mar 8, 2014
@Kwpolska Kwpolska Fix #1076 -- remove double negative settings (invert HIDE_* into SHOW…
…_*).

new                     =     old                     = default
SHOW_SOURCELINK         = not HIDE_SOURCELINK         = True
SHOW_UNTRANSLATED_POSTS = not HIDE_UNTRANSLATED_POSTS = True

Signed-off-by: Chris “Kwpolska” Warrick <kwpolska@gmail.com>
ddf93fc
@Kwpolska Kwpolska added a commit that closed this issue Mar 8, 2014
@Kwpolska Kwpolska Fix #1076 -- remove double negative settings (invert HIDE_* into SHOW…
…_*).

new                     =     old                     = default
SHOW_SOURCELINK         = not HIDE_SOURCELINK         = True
SHOW_UNTRANSLATED_POSTS = not HIDE_UNTRANSLATED_POSTS = True

Signed-off-by: Chris “Kwpolska” Warrick <kwpolska@gmail.com>
7eb949b
@Kwpolska Kwpolska closed this in 7eb949b Mar 8, 2014
@ralsina ralsina modified the milestone: v7.0.0, v6.5.0 Mar 22, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment