Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better control over teasers and descriptions? #1845

Closed
da2x opened this issue Jun 24, 2015 · 6 comments
Closed

Better control over teasers and descriptions? #1845

da2x opened this issue Jun 24, 2015 · 6 comments
Labels
Milestone

Comments

@da2x
Copy link
Contributor

@da2x da2x commented Jun 24, 2015

On one of my sites I use post.description() and post.text(teaser) in different ways in different places.

  • post.text(teaser) is used in the main index and in all feeds
  • post.description() is used in tag indexes and search
  • both post.text(teaser) and post.description() [shown below post.title() but before post.text()] is used on post pages

Should there be settings allowing more control over things like this? I’ve opted for using different texts on the different index pages to make each of the page collections more unique. Lately, I’ve thought that maybe I should include both post.description() and post.teaser() in the tags feeds as well. So far I’ve used tweaks to my themes to achieve this, but maybe there should be a built-in mechanism for this?

When wold it be useful to allow control over teaser, description, or description + teaser? SHOW_DESCRIPTIONS_ON_POSTS_PAGES? Or better defaults?

Another user asked how I was displaying the post.description() on post pages some time ago, so there is at least some interest for this.

@Kwpolska

This comment has been minimized.

Copy link
Member

@Kwpolska Kwpolska commented Jun 24, 2015

There are lots of options and different ideas to do something like this (you listed 6 decision points 4 places(index, feeds, tag indexes, post pages) × 4 options(teaser, description, text, description+text) = 16 decisions to make by my count), so I would personally leave it out of the core and interested users would just edit their themes (it’s not that hard).

Also, note that the descriptions are used in <meta> tags, which means you can’t use HTML tags, and that you can have only one short paragraph. Not a problem if you have teasers only (which you can also make stand out on post pages).

@da2x

This comment has been minimized.

Copy link
Contributor Author

@da2x da2x commented Jun 24, 2015

I guess this kind of goes back to having a template for the feeds, doesn’t it? It’s the only part of this that can’t be adjusted in a theme.

@Kwpolska

This comment has been minimized.

Copy link
Member

@Kwpolska Kwpolska commented Jun 24, 2015

Templates for RSS sound really awful. We have a fancy library that does everything for us, much easier than templates that would be modified by less than a dozen people anyways.

@da2x

This comment has been minimized.

Copy link
Contributor Author

@da2x da2x commented Jun 24, 2015

Well, it would remove the need for these options: RSS_LINKS_APPEND_QUERY, RSS_READ_MORE_LINK, RSS_TEASERS, and RSS_PLAIN while allowing more flexibility. I’m primarily thinking about a template for the main content blog of feeds (where we now supply post.teaser()).

@Kwpolska

This comment has been minimized.

Copy link
Member

@Kwpolska Kwpolska commented Jun 24, 2015

Even if we did allow for RSS templates, the options would not be removed for the benefit of beginners and people who want to change these things without messing with templates. We do the same for HTML — there are options like BODY_END, EXTRA_HEAD_DATA, SEARCH_FORM, SOCIAL_BUTTONS_CODE, MATHJAX_CONFIG, all of which take HTML input and are directly inserted in templates.

@Kwpolska

This comment has been minimized.

Copy link
Member

@Kwpolska Kwpolska commented Jul 13, 2016

Closing due to no activity in over a year.

@Kwpolska Kwpolska closed this Jul 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.