Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement mechanism to make posts depend on config options #1919

Closed
ralsina opened this issue Jul 31, 2015 · 4 comments
Closed

Implement mechanism to make posts depend on config options #1919

ralsina opened this issue Jul 31, 2015 · 4 comments
Assignees
Milestone

Comments

@ralsina
Copy link
Member

ralsina commented Jul 31, 2015

Suppose a rest directive can do things differently based on a config option (yes, abstract feature).

Currently, it would need to record a dependency on the conf.py file in order to react to config changes.

This feature would provide the directive developer a mechanism to declare a depedency on specific config key values.

@ralsina ralsina self-assigned this Jul 31, 2015
@ralsina ralsina added this to the 7.6.3 milestone Jul 31, 2015
@Kwpolska
Copy link
Member

Doing #1854, aren’t you now?

Sounds like adding a ####MAGIC####CONFIG:REST_SUBSTITUTIONS dependency (like it’s done in post lists) and some simple handling would do it.

@ralsina
Copy link
Member Author

ralsina commented Jul 31, 2015

Actually,no, this was requested by @humitos for his fotorama stuff, but yes, that would also need it, and yes, that's the plan :-)

@ralsina
Copy link
Member Author

ralsina commented Aug 5, 2015

@humitos take a look, that implementation is not tested, see the doc diff for how it's supposed to work ;-)

Kwpolska added a commit that referenced this issue Aug 5, 2015
Implement depend-on-config-options for reSt extensions (Fix Issue #1919)
@ralsina ralsina modified the milestones: 7.6.3, 7.6.4 Aug 8, 2015
@ralsina
Copy link
Member Author

ralsina commented Aug 20, 2015

Done.

@ralsina ralsina closed this as completed Aug 20, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants