Changes to sass files not causing recompilation #966

Closed
tiktuk opened this Issue Dec 28, 2013 · 4 comments

Comments

Projects
None yet
3 participants
@tiktuk

tiktuk commented Dec 28, 2013

Only when the target css file does not exist, the sass is compiled.

Here I have changed the sass which nikola correctly detects:

INFO:root:file changed: themes/style-theme/sass/style_horn.scss
Scanning posts....done!
.  prepare_sass_sources:cache/sass/style_horn.scss
INFO:root:Reload 1 waiters

But it doesn't run the build_sass task.

When I have deleted the target file first manually it works correctly:

INFO:root:file changed: themes/style-theme/sass/style_horn.scss
Scanning posts....done!
.  prepare_sass_sources:cache/sass/style_horn.scss
.  build_sass:output/assets/css/style_horn.css
INFO:root:Reload 1 waiters
@ralsina

This comment has been minimized.

Show comment Hide comment
@ralsina

ralsina Jan 29, 2014

Owner

Sorry it took so long to check this.

I don't use SASS myself, can you give me steps to reproduce from scratch?

Owner

ralsina commented Jan 29, 2014

Sorry it took so long to check this.

I don't use SASS myself, can you give me steps to reproduce from scratch?

@tiktuk

This comment has been minimized.

Show comment Hide comment
@tiktuk

tiktuk Mar 31, 2014

Hm, now I can't get it to compile sass at all. Steps:

$ nikola init --demo test
$ cd test/
$ mkcd sass

$ cat > test.scss << 'endmsg'
$font-stack:    Helvetica, sans-serif;
$primary-color: blue;

body {
  font: 100% $font-stack;
  color: $primary-color;
}
endmsg

$ echo test.scss > targets
$ nikola auto 
Scanning posts....done!
.  prepare_sass_sources:cache/sass/test.scss
Serving on 127.0.0.1:8000
INFO:root:Browser Connected: http://localhost:8000/
INFO:root:Start watching changes
INFO:root:File conf.py changed
INFO:root:ignore this reload action

It doesn't build the sass in the first place and it doesn't react to changes to the test.scss file either. So probably I'm doing something wrong? It does notice it in the prepare_sass_sources step though.

tiktuk commented Mar 31, 2014

Hm, now I can't get it to compile sass at all. Steps:

$ nikola init --demo test
$ cd test/
$ mkcd sass

$ cat > test.scss << 'endmsg'
$font-stack:    Helvetica, sans-serif;
$primary-color: blue;

body {
  font: 100% $font-stack;
  color: $primary-color;
}
endmsg

$ echo test.scss > targets
$ nikola auto 
Scanning posts....done!
.  prepare_sass_sources:cache/sass/test.scss
Serving on 127.0.0.1:8000
INFO:root:Browser Connected: http://localhost:8000/
INFO:root:Start watching changes
INFO:root:File conf.py changed
INFO:root:ignore this reload action

It doesn't build the sass in the first place and it doesn't react to changes to the test.scss file either. So probably I'm doing something wrong? It does notice it in the prepare_sass_sources step though.

@ralsina ralsina added the bug label Apr 18, 2014

@ralsina ralsina added this to the v7.0.0 milestone Apr 18, 2014

@ralsina ralsina self-assigned this Apr 18, 2014

@Kwpolska Kwpolska modified the milestones: v7.0.1, v7.0.0 May 16, 2014

@Kwpolska Kwpolska assigned Kwpolska and unassigned ralsina May 30, 2014

@Kwpolska

This comment has been minimized.

Show comment Hide comment
@Kwpolska

Kwpolska May 30, 2014

Owner

There, fixed. (the plugin is now in the Plugins Index, use nikola plugin -i sass to get it.)

Owner

Kwpolska commented May 30, 2014

There, fixed. (the plugin is now in the Plugins Index, use nikola plugin -i sass to get it.)

Kwpolska added a commit to getnikola/plugins that referenced this issue May 30, 2014

(blindly) apply fixes from getnikola/nikola#966 (6c42838)
Signed-off-by: Chris “Kwpolska” Warrick <kwpolska@gmail.com>
@tiktuk

This comment has been minimized.

Show comment Hide comment
@tiktuk

tiktuk May 31, 2014

Thanks 👍 !

tiktuk commented May 31, 2014

Thanks 👍 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment