Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid rebuild of tag/category pages/feeds when tag/category is added/removed. #1565

Merged
merged 1 commit into from Jan 3, 2015

Conversation

@felixfontein
Copy link
Contributor

@felixfontein felixfontein commented Jan 3, 2015

This patch avoids rebuilding of tag and category pages and RSS feeds if a tag or category was added or removed; this was caused because every tag and category page and RSS feed had a list of all tags and categories incorporated into its uptodate list (via kw).

Fixes #1410.

… tag or category is added or removed.
@felixfontein felixfontein added this to the v7.3.0 milestone Jan 3, 2015
@Kwpolska Kwpolska added the enhancement label Jan 3, 2015
@Kwpolska
Copy link
Member

@Kwpolska Kwpolska commented Jan 3, 2015

Previously, tag pages (eg. /tags/foo.html) had a list of all the tags in kw, because it leaked from the tag index (/tags/index.html).

Now, the tag index has the list in its own copy of kw (and only that copy has the tag list), and tag pages have a list of posts they need in uptodate that comes from the context via generic_post_list_renderer, and also depend on the post files.

Correct?

@Kwpolska Kwpolska self-assigned this Jan 3, 2015
@felixfontein
Copy link
Contributor Author

@felixfontein felixfontein commented Jan 3, 2015

Precisely. (If category and tag folder are different, then both indices have only the list they need in their copy of kw.)

Kwpolska added a commit that referenced this pull request Jan 3, 2015
Avoid rebuild of tag/category pages/feeds when tag/category is added/removed.
@Kwpolska Kwpolska merged commit 4348808 into master Jan 3, 2015
2 checks passed
2 checks passed
continuous-integration/appveyor AppVeyor build succeeded
Details
continuous-integration/travis-ci The Travis CI build passed
Details
@Kwpolska Kwpolska deleted the fix_tag_rebuilding branch Jan 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.