Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compiler config deps II #1587

Merged
merged 8 commits into from Jan 20, 2015
Merged

Compiler config deps II #1587

merged 8 commits into from Jan 20, 2015

Conversation

@ralsina
Copy link
Member

@ralsina ralsina commented Jan 17, 2015

Use add_dependency_uptodate correctly

@ralsina
Copy link
Member Author

@ralsina ralsina commented Jan 18, 2015

I think this way makes more sense. Comments appreciated :-)

@Kwpolska
Copy link
Member

@Kwpolska Kwpolska commented Jan 18, 2015

👍 from me.

@Kwpolska Kwpolska added this to the v7.3.1 milestone Jan 18, 2015
@felixfontein
Copy link
Contributor

@felixfontein felixfontein commented Jan 18, 2015

This still needs some packaging, like in a config_changed object. I'll add that.

@felixfontein
Copy link
Contributor

@felixfontein felixfontein commented Jan 18, 2015

Well, there are two things we could do:
a) ask that only correct things are put into compiler.config_dependencies;
b) change compiler.config_dependencies into a set and ask for strings to be put into it, then post.uptodate() has to create a sorted list out of it and put it into a tools.config_changed object.

Which one do you prefer?

@ralsina
Copy link
Member Author

@ralsina ralsina commented Jan 18, 2015

Let's keep the complexity in one place, otherwise for each compiler we have to know all this stuff about why it has to be a set and why it has to have a unique ID, and how unique it has to be, etc.

I'd say the compiler just has a list of strings, then the post creates a config_changed up to its own requirements out of it.

I think this is better because while there is a chance 3rd parties will want to write a compiler plugin, noone outside the project is touching Post.

@felixfontein
Copy link
Contributor

@felixfontein felixfontein commented Jan 18, 2015

Sounds good to me. And if anyone needs to add something more complex than simply a string (or several of them), or if the data depends on the post as well, they can still use the more complicated mechanism.

@Kwpolska
Copy link
Member

@Kwpolska Kwpolska commented Jan 20, 2015

Without this, nikola is broken badly. Merging.

Kwpolska added a commit that referenced this issue Jan 20, 2015
@Kwpolska Kwpolska merged commit 3d1b7be into master Jan 20, 2015
2 checks passed
@Kwpolska Kwpolska changed the title Compiler config deps Compiler config deps II Jan 20, 2015
@felixfontein
Copy link
Contributor

@felixfontein felixfontein commented Jan 20, 2015

It is indeed. But there was something missing for pandoc and markdown: the compilers also inserted a list of strings into the list (instead of strings). Merging that, too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants