Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thumbnail updates #1606

Merged
merged 3 commits into from Feb 8, 2015
Merged

Thumbnail updates #1606

merged 3 commits into from Feb 8, 2015

Conversation

@pellenilsson
Copy link
Contributor

pellenilsson commented Feb 1, 2015

Some improvements for my scale_images plugin:

  • Thumbnail images in a post would normally be larger than the thumbnails in a gallery, so thumbnail size is now controlled with a separate setting.
  • The special treatment of panorama images in galleries plugin has been turned off in scale_images since it would produce very wide thumbnails that messed up page layout.
@Kwpolska Kwpolska added this to the v7.3.1 milestone Feb 1, 2015
@Kwpolska

This comment has been minimized.

Copy link

Kwpolska commented on f2def1b Feb 1, 2015

good catch.

@Kwpolska
Copy link
Member

Kwpolska commented Feb 1, 2015

The special treatment of panorama images in galleries plugin has been turned off in scale_images since it would produce very wide thumbnails that messed up page layout.

Is there a page layout? Last time I checked, galleries just dump photos at random without any layout involved.

And at the same time, your change only destroys image quality. The thumbnails’ sizes is determined in the output HTML, and it’s not even trying to make the aspect ratio right.

Also, I’m skeptical about IMAGE_THUMBNAIL_SIZE, why not produce images of the same size everywhere and be consistent? It should also default to 180 not to break existing sites.

@pellenilsson
Copy link
Contributor Author

pellenilsson commented Feb 1, 2015

The intended usage scenario for these "thumbnails" is to have illustrations in articles that are enlargeable, like on Wikipedia and similar sites. Please see this page on my site under construction for an example (figures 3, 5 and some others are enlargeable):

http://nyckelpigan.info:8802/pantarei/posts/snowline-tutorial/

THUMBNAIL_SIZE is set a bit lower than the article width so that all images fit nicely into the layout, but figure 9 is treated as a panorama and therefore becomes far too wide to fit.

@Kwpolska
Copy link
Member

Kwpolska commented Feb 2, 2015

How would it look, if not for the panorama magic? Also, you seem to be using images here and not galleries.

I guess you could use it in the post images.

@pellenilsson
Copy link
Contributor Author

pellenilsson commented Feb 4, 2015

@Kwpolska Kwpolska self-assigned this Feb 8, 2015
@Kwpolska Kwpolska added the enhancement label Feb 8, 2015
Kwpolska added a commit that referenced this pull request Feb 8, 2015
Thumbnail updates
@Kwpolska Kwpolska merged commit 70488d5 into getnikola:master Feb 8, 2015
2 checks passed
2 checks passed
continuous-integration/appveyor AppVeyor build succeeded
Details
continuous-integration/travis-ci The Travis CI build passed
Details
@Kwpolska
Copy link
Member

Kwpolska commented Feb 8, 2015

Looks okay. Let’s make 400 the default and hope nobody notices/cares or they just set it back to 180.

Kwpolska added a commit that referenced this pull request Feb 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.