Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support tranforms to allow simpler restructuredtext extensions #1647

Merged
merged 1 commit into from Apr 7, 2015

Conversation

@mgaitan
Copy link
Contributor

@mgaitan mgaitan commented Apr 3, 2015

This patch allows Rest plugins to register Transform classes to be used in the NikolaReader instance.

see getnikola/plugins#73 as an example

@@ -241,7 +241,7 @@ def _enclosure(post, lang):
return url, length, mime


class Nikola(object):
class nikola(object):

This comment has been minimized.

@Kwpolska

Kwpolska Apr 3, 2015
Member

NO NO NO

This comment has been minimized.

@ralsina

ralsina Apr 3, 2015
Member

PEP8 peeps.

This comment has been minimized.

@Kwpolska

Kwpolska Apr 3, 2015
Member

also, god knows what depends on this name not changing

@@ -233,7 +241,7 @@ def rst2html(source, source_path=None, source_class=docutils.io.StringInput,
parser=None, parser_name='restructuredtext', writer=None,
writer_name='html', settings=None, settings_spec=None,
settings_overrides=None, config_section=None,
enable_exit_status=None, logger=None, l_add_ln=0):
enable_exit_status=None, logger=None, l_add_ln=0, site=None):

This comment has been minimized.

@Kwpolska

Kwpolska Apr 3, 2015
Member

It would be better to just pass a transforms=None argument. Also, getattr is unnecessary.

@mgaitan mgaitan force-pushed the mgaitan:rest_transforms branch from ab892b4 to 4af1a43 Apr 3, 2015
@Kwpolska Kwpolska added this to the v7.3.2 milestone Apr 7, 2015
@Kwpolska Kwpolska self-assigned this Apr 7, 2015
@Kwpolska Kwpolska merged commit 4af1a43 into getnikola:master Apr 7, 2015
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor AppVeyor build succeeded
Details
Kwpolska added a commit that referenced this pull request Apr 7, 2015
support tranforms to allow simpler restructuredtext extensions
@Kwpolska
Copy link
Member

@Kwpolska Kwpolska commented Apr 7, 2015

Merged with some fixes (site.**rst_**transforms, also guaranteed to exist)

@mgaitan
Copy link
Contributor Author

@mgaitan mgaitan commented Apr 7, 2015

Chris, let me say it: you are great!

On Tue, Apr 7, 2015 at 8:29 AM, Chris Warrick notifications@github.com
wrote:

Merged with some fixes (site._rst__transforms, also guaranteed to exist)


Reply to this email directly or view it on GitHub
#1647 (comment).

mgaitan.github.io
textosypretextos.com.ar http://textosyprextextos.com.ar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants