Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support tranforms to allow simpler restructuredtext extensions #1647

Merged
merged 1 commit into from Apr 7, 2015

Conversation

mgaitan
Copy link
Contributor

@mgaitan mgaitan commented Apr 3, 2015

This patch allows Rest plugins to register Transform classes to be used in the NikolaReader instance.

see getnikola/plugins#73 as an example

@@ -241,7 +241,7 @@ def _enclosure(post, lang):
return url, length, mime


class Nikola(object):
class nikola(object):
Copy link
Member

@Kwpolska Kwpolska Apr 3, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NO NO NO

Copy link
Member

@ralsina ralsina Apr 3, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PEP8 peeps.

Copy link
Member

@Kwpolska Kwpolska Apr 3, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also, god knows what depends on this name not changing

@Kwpolska Kwpolska added this to the v7.3.2 milestone Apr 7, 2015
@Kwpolska Kwpolska self-assigned this Apr 7, 2015
@Kwpolska Kwpolska merged commit 4af1a43 into getnikola:master Apr 7, 2015
Kwpolska added a commit that referenced this pull request Apr 7, 2015
support tranforms to allow simpler restructuredtext extensions
@Kwpolska
Copy link
Member

Kwpolska commented Apr 7, 2015

Merged with some fixes (site.**rst_**transforms, also guaranteed to exist)

@mgaitan
Copy link
Contributor Author

mgaitan commented Apr 7, 2015

Chris, let me say it: you are great!

On Tue, Apr 7, 2015 at 8:29 AM, Chris Warrick notifications@github.com
wrote:

Merged with some fixes (site._rst__transforms, also guaranteed to exist)


Reply to this email directly or view it on GitHub
#1647 (comment).

mgaitan.github.io
textosypretextos.com.ar http://textosyprextextos.com.ar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants