Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes `nikola check -l` in certain cases #1649

Closed
wants to merge 1 commit into from

Conversation

@hiliev
Copy link
Contributor

@hiliev hiliev commented Apr 4, 2015

Link checking is failing if URL_TYPE is set to absolute or full_path. In absolute mode, the wrong object is used to retrieve the path, while in full-path mode the leading / is not stripped (in addition to having the wrong object being used), therefore os.path.join() fails to prepend the output directory path.

Link checking was failing if URL_TYPE is set to ‘absolute’ or
‘full_path’.
@hiliev
Copy link
Contributor Author

@hiliev hiliev commented Apr 5, 2015

Doesn't work with non-root deployments and URL_TYPE = 'full_path'.

@hiliev hiliev closed this Apr 5, 2015
@Kwpolska
Copy link
Member

@Kwpolska Kwpolska commented Apr 5, 2015

You could’ve just fixed your patch and committed to the same repo without closing.

@hiliev
Copy link
Contributor Author

@hiliev hiliev commented Apr 5, 2015

I realised that I haven't properly followed the guidelines and haven't created a branch. Dropping and forking again seemed the easiest way to do it properly (tm).

@Kwpolska
Copy link
Member

@Kwpolska Kwpolska commented Apr 5, 2015

The branches rule is not mandatory for forks, it’s for people with access to this repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.