Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed link checker #1652

Merged
merged 6 commits into from Apr 7, 2015
Merged

Fixed link checker #1652

merged 6 commits into from Apr 7, 2015

Conversation

@hiliev
Copy link
Contributor

@hiliev hiliev commented Apr 5, 2015

This patch fixes the behaviour of nikola check -l for the cases where URL_TYPE is set to full_path or absolute (issue #1650). It also fixes the use of SITE_URL instead of BASE_URL when determining the relative portion of the path in the absolute case, which leads to bogus broken link reports when both variables are set in the configuration file and have different values.

hiliev added 3 commits Apr 5, 2015
This patch fixes two issues: 'str' object has no attribute 'path' error
message and wrong computation of the relative file path with full-path
URLs and non-root deployment (e.g. BASE_URL =
‘http://getnikola.com/foo/')
This reverts commit d0117e7.
@Kwpolska
Copy link
Member

@Kwpolska Kwpolska commented Apr 5, 2015

@hiliev
Copy link
Contributor Author

@hiliev hiliev commented Apr 5, 2015

I guess, I have to find a Windows system and really fix it.

Do not strip the first character in the path.
Kwpolska added a commit that referenced this issue Apr 7, 2015
@Kwpolska Kwpolska merged commit c4770e3 into getnikola:master Apr 7, 2015
2 checks passed
@Kwpolska
Copy link
Member

@Kwpolska Kwpolska commented Apr 7, 2015

Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants