Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sanitize default IMAGE_FOLDERS output #1663

Merged
merged 2 commits into from Apr 23, 2015

Conversation

Projects
None yet
2 participants
@Kwpolska
Copy link
Member

commented Apr 22, 2015

Change the default (litter files in /) to something saner (/images/).

@Kwpolska Kwpolska added this to the v7.3.2 milestone Apr 22, 2015

@Kwpolska Kwpolska self-assigned this Apr 22, 2015

@Kwpolska

This comment has been minimized.

Copy link
Member Author

commented Apr 22, 2015

any opinions on this? @ralsina, @pellenilsson?

sanitize default IMAGE_FOLDERS output
Signed-off-by: Chris Warrick <kwpolska@gmail.com>

@Kwpolska Kwpolska force-pushed the fix-image_folders-default branch from 6b6516f to 8741301 Apr 22, 2015

@pellenilsson

This comment has been minimized.

Copy link
Contributor

commented Apr 23, 2015

Personally I use the images directory in the same way as the files directory, so if I want an image to end up in /posts/example-post/assets/images/img.png I would put it in /images/posts/example-post/assets/images/img.png. That way I can have the images sorted after what post they belong to.

But installing all images in /images constitutes another well ordered strategy, and the setting can always be overridden by the user, so I have no strong opinions on this one.

If changing this, you may want to edit the handbook under the Image Galleries header a bit (the fourth paragraph and the code block).

document #1663
Signed-off-by: Chris Warrick <kwpolska@gmail.com>

Kwpolska added a commit that referenced this pull request Apr 23, 2015

Merge pull request #1663 from getnikola/fix-image_folders-default
Sanitize default IMAGE_FOLDERS output

@Kwpolska Kwpolska merged commit 8840157 into master Apr 23, 2015

0 of 2 checks passed

continuous-integration/appveyor Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details

@Kwpolska Kwpolska deleted the fix-image_folders-default branch Apr 23, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.