Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Atom syndication, pages, and archives for indexes and tag indexes #1677

Merged
merged 5 commits into from May 4, 2015
Merged

Conversation

@da2x da2x force-pushed the task-atom branch from c7e9d0a to edcba25 May 3, 2015
@@ -557,7 +557,7 @@ INDEX_READ_MORE_LINK = ${INDEX_READ_MORE_LINK}
RSS_READ_MORE_LINK = ${RSS_READ_MORE_LINK}

# Append a URL query to the RSS_READ_MORE_LINK and the //rss/item/link in
# RSS feeds. Minimum example for Piwik "pk_campaign=rss" and Google Analytics
# Atom and feeds. Minimum example for Piwik "pk_campaign=rss" and Google Analytics

This comment has been minimized.

@Kwpolska

Kwpolska May 3, 2015
Member

make it clear: Atom and RSS feeds.

<body>
<h1><xsl:value-of select="feed/title"/> (Atom feed)</h1>
<p>This is an Atom feed. To subscribe to it, copy its address and paste it when your feed reader asks for it. It will be updated periodically in your reader. New to feeds? <a href="https://duckduckgo.com/?q=how+to+get+started+with+rss+feeds" title="Search on the web to learn more">Learn more</a>.</p>
<p>

This comment has been minimized.

@Kwpolska

Kwpolska May 3, 2015
Member

The search query still says rss.

On a side note, could you make it possible to discourage people from using feeds for subpages (index-1 etc.)? I have absolutely no idea how this all works and if this is possible; maybe you could create two XSL files with different text for the two cases.

This comment has been minimized.

@da2x

da2x May 3, 2015
Author Contributor

Intentional. The results were better than when changing the query to Atom. You’d be hard-pressed to find something calling itself an RSS reader that didn’t support Atom anyways.

That is the job of <link rel="current"> inside the non-current feeds. Could display the current address itself. Would be a bit more complicated as current doesn’t contain current only self.

Paginated current and archived feeds for indexes. New option
GENERATE_ATOM is off by default.
@da2x da2x force-pushed the task-atom branch from edcba25 to 0def2e0 May 3, 2015
Substitutions for RSS_LINKS_APPEND_QUERY for identifying the source
feed address (feedRelUri) and the kind of feed (feedFormat).
@@ -753,12 +757,21 @@ COMMENT_SYSTEM_ID = ${COMMENT_SYSTEM_ID}
# links to it. Set this to False to disable everything RSS-related.
# GENERATE_RSS = True

# By default, Nikola does not generates Atom files for indexes and links to
# them. Generate Atom for tags by setting TAG_PAGES_ARE_INDEXES to True.
# Atom feeds are built based on INDEX_DISPLAY_POST_COUNT and not FEED_LENGHT

This comment has been minimized.

@Kwpolska

Kwpolska May 4, 2015
Member

LENGTH*

fixed

# Switch between plain-text summaries and full HTML content using the
# RSS_TEASER option. RSS_LINKS_APPEND_QUERY is also respected. Atom feeds
# are generated even for old indexes and have pagination link relations
# between each other. Old Atom feeds were no changes are marked as archived.

This comment has been minimized.

@Kwpolska

Kwpolska May 4, 2015
Member

with no changes*?

fixed

<meta charset="UTF-8"/>
<meta name="viewport" content="width=device-width"/>
<title><xsl:value-of select="feed/title"/> (Atom feed)</title>
<style><![CDATA[html{margin:0;pdding:0;}body{color:hsl(180,1%,31%);font-family:Helvetica,Arial,sans-serif;font-size:17px;line-height:1.4;margin:5%;max-width:35rem;padding:0;}input{min-width:20rem;margin-left:.2rem;padding-left:.2rem;padding-right:.2rem;}ol{list-style-type:disc;padding-left:1rem;}h2{font-size:22px;font-weight:inherit;}]]></style>

This comment has been minimized.

@Kwpolska

Kwpolska May 4, 2015
Member

padding*

(also broken in rss.xsl)

both fixed

@Kwpolska
Copy link
Member

@Kwpolska Kwpolska commented May 4, 2015

Couldn’t we handle the tags without forcing tag indexes?

@Kwpolska Kwpolska modified the milestone: v7.3.2 May 4, 2015
Kwpolska and others added 3 commits May 4, 2015
Signed-off-by: Chris Warrick <kwpolska@gmail.com>
* Autodiscoverable feeds for archive and tag index pages
* Generate paginated and properly archived feeds for archive indexes
@da2x da2x merged commit 728dd37 into master May 4, 2015
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/travis-ci/push The Travis CI build failed
Details
continuous-integration/appveyor AppVeyor build succeeded
Details
@Kwpolska Kwpolska deleted the task-atom branch Jun 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants