Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1695 #1705

Merged
merged 1 commit into from May 8, 2015
Merged

Fix #1695 #1705

merged 1 commit into from May 8, 2015

Conversation

@ralsina
Copy link
Member

@ralsina ralsina commented May 8, 2015

This avoids the unicode/bytes error under python3, BUT it still keeps the ed2k URL url-encoded llike this

<p>Here is an <a class="reference external" href="ed2k://%7Cfile%7CAudioBook-OrsonWelles-WarOfTheWorlds,Original,Uncut.mp3%7C54878208%7CB7E6517C258F0062832629718E91FFBC%7C/">eD2k link</a></p>

I have no idea if those are valid or not. @chaghi can you check?

@chaghi
Copy link

@chaghi chaghi commented May 8, 2015

@ralsina it works.

The URL encoding doesn't seem to be a problem, at least with Firefox 37 and aMule 2.3.1 on Linux. If you click the (encoded) link on the rendered page, you get prompted by Firefox to handle it with aMule, and aMule parses it all right and starts the download.

ralsina added a commit that referenced this pull request May 8, 2015
@ralsina ralsina merged commit fcf1e15 into master May 8, 2015
3 checks passed
3 checks passed
continuous-integration/appveyor AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@ralsina ralsina deleted the flog-the-donkey branch May 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants