Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #1688 #1719

Merged
merged 9 commits into from May 19, 2015
Merged

fix #1688 #1719

merged 9 commits into from May 19, 2015

Conversation

@ralsina
Copy link
Member

ralsina commented May 12, 2015

This makes the post-list directive only trigger a rebuild of a post if the timeline changes.

OTOH:

  1. It makes the posts plugin a bit more dense
  2. I suspect this is racy as hell in multicore builds (which I hope noone does since I never worried before ;)
ralsina added 2 commits May 12, 2015
@Kwpolska
Copy link
Member

Kwpolska commented May 12, 2015

I’ve heard some people do multi-core builds. What would crash for them?

@ralsina
Copy link
Member Author

ralsina commented May 12, 2015

Not crash, but limited testing shows some times not everything will be built. That already happens with sitemap, for example, this is building from scratch using -n8:

.  render_tags:output/categories/cat_nikola.xml
.  render_pages:output/posts/foo16.html
.  sitemap:output/sitemap.xml
.  sitemap:output/sitemapindex.xml
.  robots_file:output/robots.txt
(nikola)ralsina@yoga:~/Desktop/proyectos/nikola/master/foo$ 
(nikola)ralsina@yoga:~/Desktop/proyectos/nikola/master/foo$ nikola build -n 8
Scanning posts....done!
.  sitemap:output/sitemap.xml
.  sitemap:output/sitemapindex.xml
(nikola)ralsina@yoga:~/Desktop/proyectos/nikola/master/foo$ nikola build -n 8
Scanning posts....done!
(nikola)ralsina@yoga:~/Desktop/proyectos/nikola/master/foo$ 

You can see how the 1st run left the sitemap unbuilt, and then the 2nd one does it.

@Kwpolska

This comment has been minimized.

Copy link
Member

Kwpolska commented on 7b6a984 May 14, 2015

What is the use for this __repr__ change? Is there no better place to do this in?

This comment has been minimized.

Copy link
Member Author

ralsina replied May 14, 2015

I want Nikola.timeline to change when posts content and/or metadata change.

ralsina added 3 commits May 14, 2015
ralsina added a commit that referenced this pull request May 19, 2015
@ralsina ralsina merged commit 156e49c into master May 19, 2015
0 of 3 checks passed
0 of 3 checks passed
continuous-integration/appveyor Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
@ralsina ralsina deleted the fix-1688 branch May 19, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.