Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto bower #1739

Merged
merged 4 commits into from May 23, 2015
Merged

Auto bower #1739

merged 4 commits into from May 23, 2015

Conversation

@ralsina
Copy link
Member

ralsina commented May 20, 2015

Script to update and symlink bower dependencies (Issue #1737)

ralsina added 2 commits May 20, 2015
@Kwpolska
Copy link
Member

Kwpolska commented May 21, 2015

It should also take care of jinja themes.

@ralsina
Copy link
Member Author

ralsina commented May 21, 2015

I think jinjify should handle that, instead.

@ralsina
Copy link
Member Author

ralsina commented May 22, 2015

@Kwpolska what do you think about merging this as a 1st iteration?

pushd nikola/data/themes/bootstrap3/assets/js/
ln -sf ../../../../../../bower_components/bootstrap/dist/js/*js .
rm npm.js
git add *js

This comment has been minimized.

Copy link
@Kwpolska

Kwpolska May 23, 2015

Member

git add * can be problematic. use git add . to add everything in the current working directory.

@Kwpolska
Copy link
Member

Kwpolska commented May 23, 2015

Change the git add command, add git commit -am 'bower update' and merge.

Signed-off-by: Chris Warrick <kwpolska@gmail.com>
@Kwpolska Kwpolska added this to the 7.5.0 milestone May 23, 2015
@Kwpolska Kwpolska self-assigned this May 23, 2015
Signed-off-by: Chris Warrick <kwpolska@gmail.com>
@Kwpolska
Copy link
Member

Kwpolska commented May 23, 2015

Done. I also added Jinja asset updates for the two bootstrap themes to jinjify.py (done via copying). Merging.

Kwpolska added a commit that referenced this pull request May 23, 2015
Auto bower
@Kwpolska Kwpolska merged commit a3b940d into master May 23, 2015
0 of 3 checks passed
0 of 3 checks passed
continuous-integration/appveyor Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
@Kwpolska Kwpolska deleted the auto-bower branch May 23, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.