Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #1747 #1751

Merged
merged 2 commits into from May 24, 2015
Merged

fix #1747 #1751

merged 2 commits into from May 24, 2015

Conversation

@ralsina
Copy link
Member

ralsina commented May 23, 2015

Remove empty/Falsish values from post metadata when hashing it for repr.

This doesn't break "post repr should change if metadata changes" because when a Falsish value becomes truish it will change the hash.

@felixfontein can you take a look since this is your idea and I can't reproduce the bug? :-)

clean_meta = {}
for k, v in self.meta.items():
if v:
clean_meta[k] = v

This comment has been minimized.

Copy link
@felixfontein

felixfontein May 23, 2015

Contributor

This unfortunately doesn't work: the problem is that meta is a dict from language to another dict, and the inner dict is the problem. I'll fix that.

@felixfontein
Copy link
Contributor

felixfontein commented May 23, 2015

I have no idea why it only happens to me, but here it is perfectly reproduceable with two different machines (set up quite similarly, though). Anyway, with that change, it stops rebuilding more than once for me.

ralsina added a commit that referenced this pull request May 24, 2015
fix #1747
@ralsina ralsina merged commit b061fb9 into master May 24, 2015
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor AppVeyor build succeeded
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@ralsina ralsina deleted the 1747 branch May 24, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.