Smarter check #1759
Smarter check #1759
Conversation
|
@felixfontein I'd like your review of this one |
| def _call_nikola_list(site): | ||
| files = [] | ||
| for task in generate_tasks('render_site', site.gen_tasks('render_site', "Task", '')): | ||
| files.extend(task.targets) |
This won't work if any of the generated tasks has a delayed task loader, but a) probably no plugin author does that, and b) I have to go through that anyway when adjusting this for the earlytask_impl branch, so I vote for leaving this as is for the moment.
Ack.
| def _call_nikola_list(site): | ||
| files = [] | ||
| deps = defaultdict(list) | ||
| for task in generate_tasks('render_site', site.gen_tasks('render_site', "Task", '')): |
Is this safe? Are we not doing it twice?
We should probably talk to our task loader anyways.
It works anyway. To talk to our taskloader we'd have to move it out of __main__ first.
You can just talk to self.site.doit.task_loader. You also can save the generated tasks there, if any.
I tried it, see no difference, and I don't understand internals well enough, maybe.
So, proposing to merge this as-is.
|
Before merging: what is that problem with the |
| for target in task.targets: | ||
| deps[target].extend(task.file_dep) | ||
| for task in generate_tasks('post_render', site.gen_tasks('render_site', "LateTask", '')): | ||
| files.extend(task.targets) |
Don't you need the lines updating deps[target] here as well?
You are correct. Good catch! Fixing...
|
The output of the demo site changes because I fixed a broken link generated by the listings plugin, I think. |
|
Ah ok. Then everything's fine from my POV :) |
Fix #1758 and hopefully breaks nothing ;-)
The text was updated successfully, but these errors were encountered: