New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1772 #1773

Merged
merged 2 commits into from Jun 1, 2015

Conversation

Projects
None yet
2 participants
@ralsina
Member

ralsina commented Jun 1, 2015

Looks like scale_images was creating files without telling doit, and check found it :-)

@ralsina

This comment has been minimized.

Member

ralsina commented Jun 1, 2015

@Kwpolska any ideas why appveyor fails here?

ralsina added a commit that referenced this pull request Jun 1, 2015

@ralsina ralsina merged commit 2c97f16 into master Jun 1, 2015

2 of 3 checks passed

continuous-integration/appveyor AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@ralsina ralsina deleted the fix-1772 branch Jun 1, 2015

@Kwpolska

This comment has been minimized.

Member

Kwpolska commented Jun 1, 2015

@ralsina it seems to be a regression introduced on the smarter-check branch:

[2015-05-31T14:09:19Z] WARNING: check: Broken link in output\listings\index.html: https://example.com/foo/listings/index.html.html 

There is probably something crazy going on with link creation in listings.

@ralsina

This comment has been minimized.

Member

ralsina commented Jun 1, 2015

Actually, that was an undetected broken link, maybe my fix was not good tho. I'll check it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment