New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1776 and all related cases #1780

Merged
merged 5 commits into from Jun 2, 2015

Conversation

Projects
None yet
2 participants
@ralsina
Member

ralsina commented Jun 1, 2015

Added basic test for #1776

da2x added some commits Jun 1, 2015

with io.open(conf_path, "a", encoding="utf8") as outf:
outf.write("""\n\nREDIRECTS = [ ("foo.html", "http://www.example.com/"), ]\n\n""")
class RedirectionsTest3(EmptyBuildTest):

This comment has been minimized.

@ralsina

ralsina Jun 1, 2015

Member

It's probably much cheaper (as in "runs a lot faster") to put all of these in a single test class if possible.

@ralsina

This comment has been minimized.

Member

ralsina commented Jun 2, 2015

Ok, so all those tests seem to pass in travis, and they pass in my computer. They still fail in yours, @Aeyoun ?

@da2x

This comment has been minimized.

Contributor

da2x commented Jun 2, 2015

It’s REDIRECTIONS, not REDIRECTS. In any case, I can’t see that it actually runs check -l on this generated site? Setting REDIRECTIONS = [ ( "test.html", "should/trigger/warning.html" ), ] does not fail either.

ralsina added some commits Jun 2, 2015

ralsina added a commit that referenced this pull request Jun 2, 2015

@ralsina ralsina merged commit cac64aa into master Jun 2, 2015

0 of 3 checks passed

continuous-integration/appveyor Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details

@ralsina ralsina deleted the really-fix-1776 branch Jun 2, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment