Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ipynb in all themes #1783

Merged
merged 10 commits into from Jun 4, 2015
Merged

ipynb in all themes #1783

merged 10 commits into from Jun 4, 2015

Conversation

@ralsina
Copy link
Member

@ralsina ralsina commented Jun 3, 2015

Enable mathjax for all ipynb posts/pages.

ralsina added 3 commits Jun 3, 2015
@Kwpolska
Copy link
Member

@Kwpolska Kwpolska commented Jun 3, 2015

👍 for this bit, want to do the other half or can I take it?

@damianavila
Copy link
Member

@damianavila damianavila commented Jun 3, 2015

Seem OK to me...

@ralsina
Copy link
Member Author

@ralsina ralsina commented Jun 3, 2015

@Kwpolska feel free, I have a cold and code will be worse than usual for a couple of days :-P

Kwpolska added 2 commits Jun 4, 2015
Signed-off-by: Chris Warrick <kwpolska@gmail.com>
Signed-off-by: Chris Warrick <kwpolska@gmail.com>
@Kwpolska Kwpolska force-pushed the start-1782 branch from 0013534 to ab8765e Jun 4, 2015
@Kwpolska
Copy link
Member

@Kwpolska Kwpolska commented Jun 4, 2015

The other half is now up for review (c3d5a4e + ab8765e).

Also, ipython blogs often want a change in mathjax config (to accept the ugly $e = mc^2$ syntax for math) — we still need that as setup for ipynb (unless you can always do \(e = mc^2\))

@Kwpolska Kwpolska changed the title part of #1782 ipynb in all themes Jun 4, 2015
@Kwpolska Kwpolska added this to the 7.5.0 milestone Jun 4, 2015
Kwpolska added 5 commits Jun 4, 2015
Signed-off-by: Chris Warrick <kwpolska@gmail.com>
Signed-off-by: Chris Warrick <kwpolska@gmail.com>
Signed-off-by: Chris Warrick <kwpolska@gmail.com>
@ralsina
Copy link
Member Author

@ralsina ralsina commented Jun 4, 2015

Looks good to me. +1

ralsina added a commit that referenced this pull request Jun 4, 2015
ipynb in all themes
@ralsina ralsina merged commit 7c73f76 into master Jun 4, 2015
1 of 3 checks passed
1 of 3 checks passed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/travis-ci/push The Travis CI build failed
Details
continuous-integration/appveyor AppVeyor build succeeded
Details
@ralsina ralsina deleted the start-1782 branch Jun 4, 2015
@damianavila
Copy link
Member

@damianavila damianavila commented Jun 5, 2015

I little bit late, but LGTM too...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants