Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fotorama directive for rst #1794

Closed
wants to merge 1 commit into from
Closed

fotorama directive for rst #1794

wants to merge 1 commit into from

Conversation

@humitos
Copy link
Member

@humitos humitos commented Jun 8, 2015

Allows to include a fotorama[1] gallery in any post.

[1] http://fotorama.io/

Allows to include a fotorama[1] gallery in any post.

[1] http://fotorama.io/
@humitos
Copy link
Member Author

@humitos humitos commented Jun 8, 2015

You can check an example here: http://argentinaenpython.com.ar/fotorama/

Loading

@ralsina
Copy link
Member

@ralsina ralsina commented Jun 8, 2015

This belongs in plugins, not in core. We are moving stuff in that direction.

Unless of course, you want to propose it as a replacement for the current slides directive, in which case it will need a few changes.

Loading


<script src="http://ajax.googleapis.com/ajax/libs/jquery/1.11.1/jquery.min.js"></script> <!-- 33 KB -->

<link href="http://cdnjs.cloudflare.com/ajax/libs/fotorama/4.6.4/fotorama.css" rel="stylesheet"> <!-- 3 KB -->
Copy link
Member

@ralsina ralsina Jun 8, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can't drop CSS link elements in the middle of the HTML, it's not standards compliant (see Notes here: https://developer.mozilla.org/en/docs/Web/HTML/Element/link ).

I'm afraid that means to support this you need to add that link element in your conf.py (EXTRA_HEAD is the option, IIRC)

Loading

Copy link
Member

@Kwpolska Kwpolska Jun 8, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could also use the template hooks for that.

Chris Warrick https://chriswarrick.com
Sent from my Galaxy S3.
On 8 Jun 2015 12:23, "Roberto Alsina" notifications@github.com wrote:

In nikola/data/themes/base/templates/embedded-fotorama.tmpl
#1794 (comment):

@@ -0,0 +1,16 @@
+## -- coding: utf-8 --
+
+<script src="http://ajax.googleapis.com/ajax/libs/jquery/1.11.1/jquery.min.js"></script>
+
+

You can't drop CSS link elements in the middle of the HTML, it's not
standards compliant (see Notes here:
https://developer.mozilla.org/en/docs/Web/HTML/Element/link ).

I'm afraid that means to support this you need to add that link element in
your conf.py (EXTRA_HEAD is the option, IIRC)


Reply to this email directly or view it on GitHub
https://github.com/getnikola/nikola/pull/1794/files#r31901731.

Loading

Copy link
Member

@ralsina ralsina Jun 8, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indeed an example on how to do that via template hooks would be awesome :-)

Loading

Copy link
Member

@Kwpolska Kwpolska Jun 8, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Loading

@Kwpolska
Copy link
Member

@Kwpolska Kwpolska commented Jun 23, 2015

@humitos Please file your PR against the themes repo, this should not be in the core.

Loading

@Kwpolska Kwpolska closed this Jun 23, 2015
@Kwpolska Kwpolska deleted the fotorama-rst-directive branch Jul 20, 2015
@humitos
Copy link
Member Author

@humitos humitos commented Aug 2, 2015

Moved here: getnikola/plugins#94

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants