Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1810 -- use watchdog in auto #1816

Merged
merged 7 commits into from Jun 15, 2015
Merged

Fix #1810 -- use watchdog in auto #1816

merged 7 commits into from Jun 15, 2015

Conversation

Kwpolska
Copy link
Member

@Kwpolska Kwpolska commented Jun 12, 2015

This is #1810.

Fixes (some of which would be useful even without watchdog):

  • make rebuilds actually work cherry-picked onto master
  • rebuild only once by using a set
  • tell people we’re rebuilding and show them the log when we’re done

Also, we have to watch the directory with conf.py and filter out events because you must watch entire directories with watchdog.

cc @ralsina

@ralsina
Copy link
Member

@ralsina ralsina commented Jun 12, 2015

You mean rebuilds were not working?

@Kwpolska
Copy link
Member Author

@Kwpolska Kwpolska commented Jun 12, 2015

yeah, I broke them in f1e95ef and nobody really noticed…

@ralsina
Copy link
Member

@ralsina ralsina commented Jun 12, 2015

let's merge this then :)

@Kwpolska
Copy link
Member Author

@Kwpolska Kwpolska commented Jun 12, 2015

So is pyyaml no longer a huge problem?

@ralsina
Copy link
Member

@ralsina ralsina commented Jun 12, 2015

Well, at least cherrypick the fix? We can merge this later, then.

Kwpolska added 3 commits Jun 12, 2015
Signed-off-by: Chris Warrick <kwpolska@gmail.com>
Signed-off-by: Chris Warrick <kwpolska@gmail.com>
Signed-off-by: Chris Warrick <kwpolska@gmail.com>
@Kwpolska
Copy link
Member Author

@Kwpolska Kwpolska commented Jun 12, 2015

done

@Kwpolska Kwpolska added this to the v7.5.2 milestone Jun 12, 2015
Kwpolska added 2 commits Jun 13, 2015
Signed-off-by: Chris Warrick <kwpolska@gmail.com>
ralsina
Copy link
Member

@ralsina ralsina commented on 81eaedf Jun 13, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd watch all the theme folder, not theme/templates because of assets.

Kwpolska
Copy link
Member Author

@Kwpolska Kwpolska commented on 81eaedf Jun 14, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in 6b43608.

@ralsina
Copy link
Member

@ralsina ralsina commented Jun 15, 2015

@Kwpolska let's merge this, dependencies be damned.

Kwpolska added a commit that referenced this issue Jun 15, 2015
@Kwpolska Kwpolska merged commit a9ee4ed into master Jun 15, 2015
@Kwpolska Kwpolska deleted the watchdog branch Jun 15, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants