New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #1810 -- use watchdog in auto #1816
Conversation
You mean rebuilds were not working? |
yeah, I broke them in f1e95ef and nobody really noticed… |
let's merge this then :) |
So is pyyaml no longer a huge problem? |
Well, at least cherrypick the fix? We can merge this later, then. |
Signed-off-by: Chris Warrick <kwpolska@gmail.com>
Signed-off-by: Chris Warrick <kwpolska@gmail.com>
Signed-off-by: Chris Warrick <kwpolska@gmail.com>
done |
Signed-off-by: Chris Warrick <kwpolska@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd watch all the theme folder, not theme/templates because of assets.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in 6b43608.
@Kwpolska let's merge this, dependencies be damned. |
This is #1810.
Fixes (some of which would be useful even without
watchdog
):make rebuilds actually workcherry-picked onto masterAlso, we have to watch the directory with
conf.py
and filter out events because you must watch entire directories withwatchdog
.cc @ralsina