Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add print CSS #1822

Merged
merged 11 commits into from Jun 21, 2015
Merged

Add print CSS #1822

merged 11 commits into from Jun 21, 2015

Conversation

@Kwpolska
Copy link
Member

Kwpolska commented Jun 13, 2015

Bootstrap & Bootstrap 3 [v2]

  • Post pages look well, meta lines have (mostly) hidden URLs and the Source link is hidden altogether; comments are hidden
  • Helvetica is used, which may or may not be a good idea v2: Switched to Garamond with fallback to Junicode
  • The only thing that is missing is the blog title, which may or may not be necessary, and that would have to be added in a different way (we would have to put a special print-only title outside of navbar).
  • Any comments?

image

Base [v1]

  • Very similar to Bootstrap’s, uses the same HTML 5 Boilerplate styles as base
  • Blog title can be added easily, but was skipped for consistency

image

Kwpolska added 5 commits Jun 13, 2015
Signed-off-by: Chris Warrick <kwpolska@gmail.com>
Signed-off-by: Chris Warrick <kwpolska@gmail.com>
Signed-off-by: Chris Warrick <kwpolska@gmail.com>
Signed-off-by: Chris Warrick <kwpolska@gmail.com>
Signed-off-by: Chris Warrick <kwpolska@gmail.com>
@Kwpolska Kwpolska added this to the v7.5.2 milestone Jun 13, 2015
@ralsina
Copy link
Member

ralsina commented Jun 13, 2015

LGTM!


/* hat tip bootstrap/html5 boilerplate */
@media print {
article .entry-title a[href]:after,

This comment has been minimized.

Copy link
@da2x

da2x Jun 13, 2015

Contributor

::pseudo-elements (two colons)

This comment has been minimized.

Copy link
@Kwpolska

Kwpolska Jun 13, 2015

Author Member

Please send your complaints to Bootstrap and HTML 5 Boilerplate first.

@@ -175,3 +175,24 @@ article.post-micro {
.entry-summary {
margin-top: 1em;
}

/* hat tip bootstrap/html5 boilerplate */
@media print {

This comment has been minimized.

Copy link
@da2x

da2x Jun 13, 2015

Contributor

Stick this in a separate file?

This comment has been minimized.

Copy link
@da2x

da2x Jun 13, 2015

Contributor

Save some ink:

* {
  background-color: #ffffff;
  color: #1c1c1c;
  font-family: Garamond, serif;
}

This comment has been minimized.

Copy link
@Kwpolska

Kwpolska Jun 13, 2015

Author Member

Garamond, I’ll accept.

Everything else, please send your complaints to Bootstrap and HTML 5 Boilerplate first.

Furthermore, printing in pure black, devoid of any complex color mixing, can make printing much faster, because the printer doesn’t have to mix in any red, green, or blue ink and can focus on getting the task done.

This comment has been minimized.

Copy link
@Kwpolska

Kwpolska Jun 13, 2015

Author Member

Done: Junicode, Garamond, serif (Junicode is an open-source font which is quite similar to Garamond and probably has similar savings in store).

Using multiple files is not really helpful. Bundles are still the default, and even if they weren’t, that’s a wasted HTTP request.

This comment has been minimized.

Copy link
@Kwpolska

Kwpolska Jun 13, 2015

Author Member

(actually, let’s put Garamond first.)

Kwpolska added 6 commits Jun 13, 2015
Signed-off-by: Chris Warrick <kwpolska@gmail.com>
Signed-off-by: Chris Warrick <kwpolska@gmail.com>
Signed-off-by: Chris Warrick <kwpolska@gmail.com>
Signed-off-by: Chris Warrick <kwpolska@gmail.com>
Signed-off-by: Chris Warrick <kwpolska@gmail.com>
@Kwpolska
Copy link
Member Author

Kwpolska commented Jun 13, 2015

Added some print CSS for base, stolen from HTML 5 Boilerplate and our Bootstrap customizations.

@ralsina, @Aeyoun: please review, both in code and in display (screenshots in the top post)

@Kwpolska Kwpolska changed the title [WIP] Print CSS Add print CSS Jun 13, 2015
@Kwpolska Kwpolska removed the in progress label Jun 13, 2015
@Kwpolska Kwpolska force-pushed the master branch from d4befbe to 8a69e98 Jun 17, 2015
@Kwpolska
Copy link
Member Author

Kwpolska commented Jun 21, 2015

Nobody felt like reviewing for the past 8 days, so I’m merging. If anything breaks, we can just fix it later.

@Kwpolska Kwpolska merged commit ef142dd into master Jun 21, 2015
1 of 3 checks passed
1 of 3 checks passed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/travis-ci/push The Travis CI build failed
Details
continuous-integration/appveyor AppVeyor build succeeded
Details
Kwpolska added a commit that referenced this pull request Jun 21, 2015
Add print CSS
@Kwpolska Kwpolska deleted the print branch Jun 21, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.