Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add print CSS #1822

Merged
merged 11 commits into from Jun 21, 2015
Merged

Add print CSS #1822

merged 11 commits into from Jun 21, 2015

Conversation

Kwpolska
Copy link
Member

@Kwpolska Kwpolska commented Jun 13, 2015

Bootstrap & Bootstrap 3 [v2]

  • Post pages look well, meta lines have (mostly) hidden URLs and the Source link is hidden altogether; comments are hidden
  • Helvetica is used, which may or may not be a good idea v2: Switched to Garamond with fallback to Junicode
  • The only thing that is missing is the blog title, which may or may not be necessary, and that would have to be added in a different way (we would have to put a special print-only title outside of navbar).
  • Any comments?

image

Base [v1]

  • Very similar to Bootstrap’s, uses the same HTML 5 Boilerplate styles as base
  • Blog title can be added easily, but was skipped for consistency

image

Kwpolska added 5 commits Jun 13, 2015
Signed-off-by: Chris Warrick <kwpolska@gmail.com>
Signed-off-by: Chris Warrick <kwpolska@gmail.com>
Signed-off-by: Chris Warrick <kwpolska@gmail.com>
Signed-off-by: Chris Warrick <kwpolska@gmail.com>
Signed-off-by: Chris Warrick <kwpolska@gmail.com>
@Kwpolska Kwpolska added this to the v7.5.2 milestone Jun 13, 2015
@ralsina
Copy link
Member

ralsina commented Jun 13, 2015

LGTM!


/* hat tip bootstrap/html5 boilerplate */
@media print {
article .entry-title a[href]:after,
Copy link
Contributor

@da2x da2x Jun 13, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

::pseudo-elements (two colons)

Copy link
Member Author

@Kwpolska Kwpolska Jun 13, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please send your complaints to Bootstrap and HTML 5 Boilerplate first.

Kwpolska added 6 commits Jun 13, 2015
Signed-off-by: Chris Warrick <kwpolska@gmail.com>
Signed-off-by: Chris Warrick <kwpolska@gmail.com>
Signed-off-by: Chris Warrick <kwpolska@gmail.com>
Signed-off-by: Chris Warrick <kwpolska@gmail.com>
Signed-off-by: Chris Warrick <kwpolska@gmail.com>
@Kwpolska
Copy link
Member Author

Kwpolska commented Jun 13, 2015

Added some print CSS for base, stolen from HTML 5 Boilerplate and our Bootstrap customizations.

@ralsina, @Aeyoun: please review, both in code and in display (screenshots in the top post)

@Kwpolska Kwpolska changed the title [WIP] Print CSS Add print CSS Jun 13, 2015
@Kwpolska
Copy link
Member Author

Kwpolska commented Jun 21, 2015

Nobody felt like reviewing for the past 8 days, so I’m merging. If anything breaks, we can just fix it later.

@Kwpolska Kwpolska merged commit ef142dd into master Jun 21, 2015
Kwpolska added a commit that referenced this pull request Jun 21, 2015
@Kwpolska Kwpolska deleted the print branch Jun 21, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants