Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix part of 1823 #1824

Merged
merged 4 commits into from Jun 30, 2015
Merged

Fix part of 1823 #1824

merged 4 commits into from Jun 30, 2015

Conversation

@ralsina
Copy link
Member

@ralsina ralsina commented Jun 15, 2015

This makes Nikola initialize LocaleBorg when called without a config file, which is needed to use the default config from importers and should have no bad side effects.

As a result of this, if you import using wordpress like this:

nikola import_wordpress foo.xml .

The config file will be loaded. However, there is still a case where this is broken:

nikola import_wordpress foo.xml myoldsite

In that case, the config will NOT be loaded, which means it will do bad things. So #1823 is not completely fixed by this.

@Kwpolska
Copy link
Member

@Kwpolska Kwpolska commented Jun 15, 2015

We could just just make the conf.py file loading part a separate function and use it from within the compilers to solve part 2 (or even do it for both parts).

@ralsina
Copy link
Member Author

@ralsina ralsina commented Jun 15, 2015

Yes, sounds like a refactor that gives us value :-)

@Kwpolska
Copy link
Member

@Kwpolska Kwpolska commented Jun 30, 2015

Guess we can merge for now.

Kwpolska added a commit that referenced this issue Jun 30, 2015
@Kwpolska Kwpolska merged commit 5a7a9e8 into master Jun 30, 2015
3 checks passed
@ralsina ralsina deleted the fix-1823 branch Jul 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants