Fixing little things in WordPress importer (WIP) #1847
Merged
Conversation
|
Parts will be fixed in #1824. Missing at the moment: exception raised by |
|
The currently failed checks are due to a disk full error on Travis, and a missing import |
| tag = utils.slugify(tag.decode('utf8')) | ||
| # In python 2, path is a str. slug requires a unicode | ||
| # object. According to wikipedia, unquoted strings will | ||
| # usually be UTF8 |
Kwpolska
Jun 30, 2015
Member
Link to that wikipedia page in code comments.
Link to that wikipedia page in code comments.
felixfontein
Jun 30, 2015
Author
Contributor
This piece is essentially a copy'n'paste from somewhere else in the same source file. The original comment has no link to Wikipedia, either.
This piece is essentially a copy'n'paste from somewhere else in the same source file. The original comment has no link to Wikipedia, either.
| # In python 2, path is a str. slug requires a unicode | ||
| # object. According to wikipedia, unquoted strings will | ||
| # usually be UTF8 | ||
| tag_str = tag.decode('utf8') if isinstance(tag, utils.bytes_str) else tag |
Kwpolska
Jun 30, 2015
Member
try:
tag_str = tag.decode('utf-8')
except AttributeError:
tag_str = tag
try:
tag_str = tag.decode('utf-8')
except AttributeError:
tag_str = tag
|
Please make this mergeable and use try/except for decoding, and you can merge as soon as Travis builds. |
|
Should I modify both occurences in this case? (The second is here: https://github.com/getnikola/nikola/blob/master/nikola/plugins/command/import_wordpress.py#L419) |
|
Ok, modified both. Now merging. |
felixfontein
added a commit
that referenced
this pull request
Jun 30, 2015
Fixing little things in WordPress importer (WIP)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
When importing a WordPress blog whose blog description was not set, I got
nullinserted intoconf.pyinstead of"PUT DESCRIPTION HERE", which causednikola buildto fail. This is fixed in 5781644.Then, there are two more problems with the WordPress importer which make it fail for me; see comments here: b6cbfcb