Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upFixing little things in WordPress importer (WIP) #1847
Conversation
felixfontein
added
the
bug
label
Jun 27, 2015
felixfontein
added this to the v7.6.0 milestone
Jun 27, 2015
This comment has been minimized.
This comment has been minimized.
|
Parts will be fixed in #1824. Missing at the moment: exception raised by |
This comment has been minimized.
This comment has been minimized.
|
The currently failed checks are due to a disk full error on Travis, and a missing import |
Kwpolska
reviewed
Jun 30, 2015
| tag = utils.slugify(tag.decode('utf8')) | ||
| # In python 2, path is a str. slug requires a unicode | ||
| # object. According to wikipedia, unquoted strings will | ||
| # usually be UTF8 |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
felixfontein
Jun 30, 2015
Author
Contributor
This piece is essentially a copy'n'paste from somewhere else in the same source file. The original comment has no link to Wikipedia, either.
Kwpolska
reviewed
Jun 30, 2015
| # In python 2, path is a str. slug requires a unicode | ||
| # object. According to wikipedia, unquoted strings will | ||
| # usually be UTF8 | ||
| tag_str = tag.decode('utf8') if isinstance(tag, utils.bytes_str) else tag |
This comment has been minimized.
This comment has been minimized.
Kwpolska
Jun 30, 2015
Member
try:
tag_str = tag.decode('utf-8')
except AttributeError:
tag_str = tag
This comment has been minimized.
This comment has been minimized.
|
Please make this mergeable and use try/except for decoding, and you can merge as soon as Travis builds. |
This comment has been minimized.
This comment has been minimized.
|
Should I modify both occurences in this case? (The second is here: https://github.com/getnikola/nikola/blob/master/nikola/plugins/command/import_wordpress.py#L419) |
felixfontein
added some commits
Jun 27, 2015
felixfontein
force-pushed the
fix-wordpress-import
branch
from
063afb9
to
c926116
Jun 30, 2015
This comment has been minimized.
This comment has been minimized.
|
Ok, modified both. Now merging. |
added a commit
that referenced
this pull request
Jun 30, 2015
felixfontein commentedJun 27, 2015
When importing a WordPress blog whose blog description was not set, I got
nullinserted intoconf.pyinstead of"PUT DESCRIPTION HERE", which causednikola buildto fail. This is fixed in 5781644.Then, there are two more problems with the WordPress importer which make it fail for me; see comments here: b6cbfcb