Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1856 -- make tag listing pages per-language #1861

Merged
merged 6 commits into from Jul 4, 2015
Merged

Conversation

@Kwpolska
Copy link
Member

@Kwpolska Kwpolska commented Jul 4, 2015

This change will display only tags that exist in this language’s posts, honoring SHOW_UNTRANSLATED_POSTS. However, the current behavior of per-tag pages is retained to help people who jump between languages by changing URLs.

cc @teknico

Review on Reviewable

Kwpolska added 4 commits Jul 4, 2015
Signed-off-by: Chris Warrick <kwpolska@gmail.com>
Signed-off-by: Chris Warrick <kwpolska@gmail.com>
Signed-off-by: Chris Warrick <kwpolska@gmail.com>
Signed-off-by: Chris Warrick <kwpolska@gmail.com>
@Kwpolska Kwpolska added this to the v7.6.1 milestone Jul 4, 2015
Kwpolska added 2 commits Jul 4, 2015
Signed-off-by: Chris Warrick <kwpolska@gmail.com>
Signed-off-by: Chris Warrick <kwpolska@gmail.com>
@teknico
Copy link

@teknico teknico commented Jul 4, 2015

Tested and it works exactly as I hoped, thanks a lot!

Brown paper bag moment: can you please resync the Italian translation from Transifex? I botched a pretty important term ("English" -> "Italiano"), fixed now.

Regarding "the current behavior of per-tag pages", pages of tags in all languages are accessible by URLs in all languages (not only their own), is that what you meant? That's fine by me.

@Kwpolska
Copy link
Member Author

@Kwpolska Kwpolska commented Jul 4, 2015

Brown paper bag moment: can you please resync the Italian translation from Transifex? I botched a pretty important term ("English" -> "Italiano"), fixed now.

That would normally be done on release, but I’ll handle it now.

Regarding "the current behavior of per-tag pages", pages of tags in all languages are accessible by URLs in all languages (not only their own), is that what you meant? That's fine by me.

Yup.

Kwpolska added a commit that referenced this pull request Jul 4, 2015
Fix #1856 -- make tag listing pages per-language
@Kwpolska Kwpolska merged commit d498e68 into master Jul 4, 2015
3 checks passed
3 checks passed
continuous-integration/appveyor AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@Kwpolska Kwpolska deleted the per-language-tags branch Jul 4, 2015
@teknico
Copy link

@teknico teknico commented Jul 4, 2015

That would normally be done on release, but I’ll handle it now.

Unfortunately the v.7.6.0 release happened in the meantime, and its Italian translation is similarly botched. I apologize. :-(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants