Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix getnikola/nikola-themes#49 -- https→http fallback #1892

Merged
merged 1 commit into from Jul 16, 2015
Merged

Conversation

@Kwpolska
Copy link
Member

@Kwpolska Kwpolska commented Jul 16, 2015

This is getnikola/nikola-themes#49.

cc @chacha92, @ralsina, @arusahni

Signed-off-by: Chris Warrick kwpolska@gmail.com

@ralsina
Copy link
Member

@ralsina ralsina commented Jul 16, 2015

I think before falling back to insecure HTTP, we should warn the user AND request confirmation. Otherwise why bother with HTTPS in the first place?

@Kwpolska
Copy link
Member Author

@Kwpolska Kwpolska commented Jul 16, 2015

I’d just add press ^C to abort — some people just don’t care, and the security-conscious will race to their keyboard anyway.

@Kwpolska
Copy link
Member Author

@Kwpolska Kwpolska commented Jul 16, 2015

Even with time.sleep(1). Makes sense?

@ralsina
Copy link
Member

@ralsina ralsina commented Jul 16, 2015

Sure, that's enough.

Signed-off-by: Chris Warrick <kwpolska@gmail.com>
ralsina added a commit that referenced this issue Jul 16, 2015
@ralsina ralsina merged commit 7c9219e into master Jul 16, 2015
3 checks passed
@ralsina ralsina deleted the ssl-workaround branch Jul 16, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants