Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[requires.io] dependency update on master branch #1896

Closed
wants to merge 1 commit into from

Conversation

@Kwpolska
Copy link
Member

Kwpolska commented Jul 17, 2015

No description provided.

@Kwpolska
Copy link
Member Author

Kwpolska commented Jul 17, 2015

Stupid computers.

DO NOT MERGE.

Signed-off-by: Chris Warrick <kwpolska@gmail.com>
@Kwpolska Kwpolska force-pushed the requires-io-master branch from 3c5c9b2 to 94afa94 Jul 20, 2015
@Kwpolska
Copy link
Member Author

Kwpolska commented Jul 20, 2015

mock==1.2.0, which undid the things that broke in 1.1.3, breaks some of our tests. No way to write compatible code? LOVELY.

Someone bored can fix it, or leave it be.

@ralsina
Copy link
Member

ralsina commented Jul 20, 2015

So, the fixes for 1.1.4 break again in 1.2.0? I can check that later :-)

@ralsina
Copy link
Member

ralsina commented Jul 20, 2015

To be honest, 1.2.0 seems broken to me:

-> meta_data = [x.strip() for x in meta_file.readlines()]
(Pdb) meta_file.readlines()
u'.. title: Nikola needs more tests!\n.. date: 2012/09/15 19:52:05\n.. tags:\n.. link:\n.. description:\n\nPost content\n'
(Pdb) meta_file.seek(0)
<MagicMock name='open().seek()' id='140399406068560'>
(Pdb) meta_file.read()
'.. title: Nikola needs more tests!\n.. date: 2012/09/15 19:52:05\n.. tags:\n.. link:\n.. description:\n\nPost content\n'

read() and readlines() return the same thing, and readlines() is not splitting in lines at all.

@Kwpolska
Copy link
Member Author

Kwpolska commented Jul 20, 2015

Woah. Mind reporting upstream?

@ralsina
Copy link
Member

ralsina commented Jul 20, 2015

@Kwpolska Kwpolska closed this Jul 21, 2015
@Kwpolska Kwpolska deleted the requires-io-master branch Jul 21, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.