Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #1898 #1899

Merged
merged 4 commits into from Jul 20, 2015
Merged

fix #1898 #1899

merged 4 commits into from Jul 20, 2015

Conversation

@ralsina
Copy link
Member

@ralsina ralsina commented Jul 20, 2015

Rewrite crazy metadata extraction thingie.

match = re_meta(line)
if match[0]:
meta[match[0]] = match[1]
seen_meta_flag = True

This comment has been minimized.

@Kwpolska

Kwpolska Jul 20, 2015
Member

unused

if re_rst_title.findall(line) and i > 0:
meta['title'] = meta_data[i - 1].strip()
if 'title' not in meta:

This comment has been minimized.

This comment has been minimized.

@Kwpolska

Kwpolska Jul 20, 2015
Member

wait, that’s deleted, I’m blind

This comment has been minimized.

@ralsina

ralsina Jul 20, 2015
Author Member

still WIP, forgot to mark it, ignore for a couple of hours, sorry :-)

@ralsina ralsina changed the title fix #1898 WIP fix #1898 Jul 20, 2015
@ralsina ralsina changed the title WIP fix #1898 fix #1898 Jul 20, 2015
Kwpolska added a commit that referenced this pull request Jul 20, 2015
@Kwpolska Kwpolska merged commit 58e1d8c into master Jul 20, 2015
1 of 3 checks passed
1 of 3 checks passed
continuous-integration/appveyor AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@Kwpolska Kwpolska deleted the fix-1898 branch Jul 20, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants