Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for #1906 #1910

Merged
merged 3 commits into from Aug 5, 2015
Merged

fix for #1906 #1910

merged 3 commits into from Aug 5, 2015

Conversation

@ralsina
Copy link
Member

ralsina commented Jul 24, 2015

This is a proposed fix for #1906. I am not able to reproduce that at this moment, so I need someone who experiences it to check the fix (@Aeyoun maybe?)

ralsina added 2 commits Jul 24, 2015
@da2x
Copy link
Contributor

da2x commented Jul 24, 2015

  1. Reload once and reload again while it’s loading
  2. touch posts/somefile.txt
  3. touch posts/new-file.txt

Nikola wouldn’t rebuild anymore but will continue serving the same content until you restart auto. Not producing any messages about file events anymore. Will continue serving the browser and will display load messages as usual.

Exception in thread Thread-1:
Traceback (most recent call last):
File "/usr/lib/python3.4/threading.py", line 920, in _bootstrap_inner
self.run()
File "/usr/local/lib/python3.4/dist-packages/watchdog/observers/api.py", line 199, in run
self.dispatch_events(self.event_queue, self.timeout)
File "/usr/local/lib/python3.4/dist-packages/watchdog/observers/api.py", line 368, in dispatch_events
handler.dispatch(event)
File "/usr/local/lib/python3.4/dist-packages/watchdog/events.py", line 322, in dispatch
self.on_any_event(event)
File "/usr/local/lib/python3.4/dist-packages/nikola/plugins/command/auto/init.py", line 394, in on_any_event
self.function(event)
File "/usr/local/lib/python3.4/dist-packages/nikola/plugins/command/auto/init.py", line 276, in do_refresh
refresh_signal.send(path=p)
File "/usr/local/lib/python3.4/dist-packages/blinker/base.py", line 267, in send
for receiver in self.receivers_for(sender)]
File "/usr/local/lib/python3.4/dist-packages/blinker/base.py", line 267, in
for receiver in self.receivers_for(sender)]
File "/usr/local/lib/python3.4/dist-packages/nikola/plugins/command/auto/init.py", line 365, in notify
self.send(response, response.is_binary)
File "/usr/local/lib/python3.4/dist-packages/ws4py/websocket.py", line 265, in send
self._write(data)
File "/usr/local/lib/python3.4/dist-packages/ws4py/websocket.py", line 241, in _write
raise RuntimeError("Cannot send on a terminated websocket")
RuntimeError: Cannot send on a terminated websocket

@Kwpolska
Copy link
Member

Kwpolska commented Jul 24, 2015

On a side note, I was getting that broken pipe issue in the past. It was around that time when I implemented nikola serve -d and nikola auto --no-server. Auto is really a weird thing.

ralsina added a commit that referenced this pull request Aug 5, 2015
fix for #1906
@ralsina ralsina merged commit 046bc8f into master Aug 5, 2015
0 of 3 checks passed
0 of 3 checks passed
continuous-integration/appveyor Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
@ralsina ralsina deleted the fix-1906 branch Aug 5, 2015
@keikoro
Copy link

keikoro commented Aug 28, 2017

I see this was closed two years ago, but I'm getting this error a lot when using nikola auto. However, it seems to only happen with Firefox. It annoyed me enough I decided to try it with Chrome and suddenly this problem is gone.

Chrome is not my default browser though, so I have to switch between more windows now.

Anyway, not sure if I should reopen/create a new issue/...

@keikoro
Copy link

keikoro commented Aug 28, 2017

Oops, just saw this wasn't actually an issue but a PR. (But, the log output included here is more similar to mine than the log messages in the linked issue.)

@Kwpolska
Copy link
Member

Kwpolska commented Aug 29, 2017

nikola auto was overhauled recently as part of v8 work. Could you test the master branch from GitHub and check if you get any errors like that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.