Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Fix #1900 -- render ipynb in listings #1920

Merged
merged 1 commit into from Jul 31, 2015

Conversation

Projects
None yet
3 participants
Owner

Kwpolska commented Jul 31, 2015

This is #1900.

cc @ralsina, @damianavila

Signed-off-by: Chris Warrick kwpolska@gmail.com

Fix #1900 -- render ipynb in listings
Signed-off-by: Chris Warrick <kwpolska@gmail.com>

@Kwpolska Kwpolska added this to the 7.6.3 milestone Jul 31, 2015

Owner

ralsina commented Jul 31, 2015

Well, it looks ok, and I trust you that it works but it's just special casing :-(

I am +0 but go ahead and merge it if you want.

Owner

damianavila commented Jul 31, 2015

Do you have somewhere an example to take a look? I did not use listing before, but IIRC, it puts the code snippet in your post an create a link to a page inside the listing folder... so I suspect that render OK on the listing page, but what about the snippet inside the post and how it renders if the notebook have markdown cells inside the snippet?

Owner

ralsina commented Jul 31, 2015

I havenot tried this but I suspect the listings directive will just show nicely highlighted json (or not even highlighted, depending on how it guesses). Which is ok, it just means you can't embed notebooks that way, just like before.

It could even error out if you try to do that.

Owner

Kwpolska commented Jul 31, 2015

Yeah: listings in posts are going to show JSON, and it does not guess anything (you have to specify json yourself). Listings can also be displayed standalone, and this is what this changes.

Standalone:
image

In post/page:
image

Owner

damianavila commented Jul 31, 2015

OK, and what about the start start-after and end-before, how that plays here? (sorry to not test by myself, just commenting on the fly, in the middle of some stuff).

Owner

Kwpolska commented Jul 31, 2015

Those don’t apply in standalone listings, only in posts (where you would just cut JSON in parts at random)

Kwpolska added a commit that referenced this pull request Jul 31, 2015

Merge pull request #1920 from getnikola/ipynb-listings
Fix #1900 -- render ipynb in listings

@Kwpolska Kwpolska merged commit 15217bc into master Jul 31, 2015

3 checks passed

continuous-integration/appveyor AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@Kwpolska Kwpolska deleted the ipynb-listings branch Jul 31, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment