Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comment out <base> elements when serving from auto #1928

Merged
merged 2 commits into from Aug 5, 2015

Conversation

Projects
None yet
2 participants
@da2x
Copy link
Contributor

commented Aug 5, 2015

Restores local resource loading and URL resolution in nikola auto regardless of the outcome of #1922.

nikola serve is a different problem because of the inflexible Content-Length implementation there; although the solution would essentially look the same as this right here. Starting with auto before proceeding with serve.

@da2x da2x self-assigned this Aug 5, 2015

@ralsina

This comment has been minimized.

Copy link
Member

commented Aug 5, 2015

LGTM add docstrings (see travis run) and merge at will :-)

da2x added a commit that referenced this pull request Aug 5, 2015

Merge pull request #1928 from getnikola/auto_re-base
Comment out <base> elements when serving via auto

@da2x da2x merged commit 682f80d into master Aug 5, 2015

3 checks passed

continuous-integration/appveyor AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@da2x da2x deleted the auto_re-base branch Aug 5, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.