Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upComment out <base> elements when serving from auto #1928
Conversation
da2x
self-assigned this
Aug 5, 2015
This comment has been minimized.
This comment has been minimized.
|
LGTM add docstrings (see travis run) and merge at will :-) |
da2x
added a commit
that referenced
this pull request
Aug 5, 2015
da2x
merged commit 682f80d
into
master
Aug 5, 2015
da2x
deleted the
auto_re-base
branch
Aug 5, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
da2x commentedAug 5, 2015
Restores local resource loading and URL resolution in
nikola autoregardless of the outcome of #1922.nikola serveis a different problem because of the inflexible Content-Length implementation there; although the solution would essentially look the same as this right here. Starting withautobefore proceeding withserve.