Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change wording in teaser comments #1937

Closed
wants to merge 1 commit into from

Conversation

@Wayneoween
Copy link

Wayneoween commented Aug 10, 2015

I was confused that this setting may change some other stuff too.
imho this describes the effect better.

@Kwpolska

This comment has been minimized.

Copy link
Member

Kwpolska commented Aug 11, 2015

I'm not sure about this... "Show only teasers" makes sense IMO, where "Activate" is vague.

@Wayneoween

This comment has been minimized.

Copy link
Author

Wayneoween commented Aug 11, 2015

Ok, it was just a thought anyways and English is not my first language, so there may be that.

"Show only" sounds to me like it excludes teasers from somewhere else. Maybe "Use teasers" is better?

@ralsina

This comment has been minimized.

Copy link
Member

ralsina commented Aug 11, 2015

I agree with @Kwpolska ... if any native english speakers see this and can comment, much appreciated :-)

@Kwpolska

This comment has been minimized.

Copy link
Member

Kwpolska commented Aug 11, 2015

I believe we should phrase it like this:

Show teasers (instead of full posts) in indexes/feeds? Defaults to False.

This makes it more clear, and also fixes awkward syntax (“Show only”).

PS. I actually have a very fancy certificate that proves I speak English on a near-native level (CEFR C2).

Chris Warrick https://chriswarrick.com/
Sent from my Galaxy S3.

On Tue, Aug 11, 2015 at 12:31 PM, Roberto Alsina notifications@github.com
wrote:

I agree with @Kwpolska ... if any native english speakers see this and can comment, much appreciated :-)

Reply to this email directly or view it on GitHub:
#1937 (comment)

@ralsina

This comment has been minimized.

Copy link
Member

ralsina commented Aug 11, 2015

@Kwpolska hey, one of my favourite english writers was a pole :)

@Kwpolska

This comment has been minimized.

Copy link
Member

Kwpolska commented Aug 11, 2015

Who is it?

Also, would you mind implementing the revised description above?

Chris Warrick https://chriswarrick.com/
Sent from my Galaxy S3.

On Tue, Aug 11, 2015 at 3:09 PM, Roberto Alsina notifications@github.com
wrote:

@Kwpolska hey, one of my favourite english writers was a pole :)

Reply to this email directly or view it on GitHub:
#1937 (comment)

@ralsina ralsina closed this in e1cdb06 Aug 11, 2015
@ralsina

This comment has been minimized.

Copy link
Member

ralsina commented Aug 11, 2015

@Kwpolska Jseph Conrad! Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.