Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite srcset links, Fix #1939 #1960

Merged
merged 8 commits into from Aug 21, 2015
Merged

Rewrite srcset links, Fix #1939 #1960

merged 8 commits into from Aug 21, 2015

Conversation

@ralsina
Copy link
Member

ralsina commented Aug 21, 2015

No description provided.

@ralsina
Copy link
Member Author

ralsina commented Aug 21, 2015

@Aeyoun review much appreciated :-)

@da2x
Copy link
Contributor

da2x commented Aug 21, 2015

Seems only the first link in the item in the srcset is rewritten.

This input:

srcset="/images/xbox_logo_128.webp 128w,
        /images/xbox_logo_256.webp 256w,
        /images/xbox_logo_512.webp 512w,
        /images/xbox_logo_1024.webp 1024w"

Produced this output:

srcset="../images/xbox_logo_128.webp 128w,
          /images/xbox_logo_256.webp 256w,
          /images/xbox_logo_512.webp 512w,
          /images/xbox_logo_1024.webp 1024w"
@ralsina
Copy link
Member Author

ralsina commented Aug 21, 2015

@Aeyoun weird.... I'll take another look then.

@ralsina
Copy link
Member Author

ralsina commented Aug 21, 2015

@Aeyoun leading spaces did weird things. Should work better now.

@da2x
Copy link
Contributor

da2x commented Aug 21, 2015

Looks good. 👍

Took a while to verify as I’d messed up the formatting of this almost everywhere in my site. Kept blaming the code but every instance was me throwing very broken markup at it.

da2x added a commit that referenced this pull request Aug 21, 2015
Rewrite srcset links,  Fix #1939
@da2x da2x merged commit 2b9b86a into master Aug 21, 2015
3 checks passed
3 checks passed
continuous-integration/appveyor AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@ralsina ralsina deleted the fix-1939 branch Aug 22, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.